optimize dot check msg #8051
Merged
optimize dot check msg #8051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyg1997
approved these changes
Apr 22, 2022
|
顺便加一个异常单测 |
liufengwei0103
requested review from
BBuf,
daquexian and
jackalcooper
as code owners
已加单测 |
hjchen2
reviewed
Apr 28, 2022
| @@ -31,6 +31,28 @@ def test_dot(test_case): | |||
| z = torch.dot(x, y) | |||
| return z | |||
|
|
|||
| def test_dot_shape_error_msg(test_case): | |||
| with test_case.assertRaises(flow._oneflow_internal.exception.Exception) as exp: | |||
There was a problem hiding this comment.
“flow._oneflow_internal.exception.Exception”改成“RuntimeException”
There was a problem hiding this comment.
而且这个异常测试应该放到test/exceptions目录下去
There was a problem hiding this comment.
而且这个异常测试应该放到test/exceptions目录下去
已放
There was a problem hiding this comment.
“flow._oneflow_internal.exception.Exception”改成“RuntimeException”
RuntimeError也行吧？
BBuf
approved these changes
May 9, 2022
liufengwei0103
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
|
View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/8051/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.