-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize dot check msg #8051
optimize dot check msg #8051
Conversation
顺便加一个异常单测 |
已加单测 |
@@ -31,6 +31,28 @@ def test_dot(test_case): | |||
z = torch.dot(x, y) | |||
return z | |||
|
|||
def test_dot_shape_error_msg(test_case): | |||
with test_case.assertRaises(flow._oneflow_internal.exception.Exception) as exp: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“flow._oneflow_internal.exception.Exception”改成“RuntimeException”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
而且这个异常测试应该放到test/exceptions目录下去
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
而且这个异常测试应该放到test/exceptions目录下去
已放
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“flow._oneflow_internal.exception.Exception”改成“RuntimeException”
RuntimeError也行吧?
View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/8051/ |
No description provided.