Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize dot check msg #8051

Merged
merged 14 commits into from
May 9, 2022
Merged

optimize dot check msg #8051

merged 14 commits into from
May 9, 2022

Conversation

liufengwei0103
Copy link
Contributor

No description provided.

@liufengwei0103 liufengwei0103 requested a review from wyg1997 April 19, 2022 08:19
@hjchen2
Copy link
Contributor

hjchen2 commented Apr 28, 2022

顺便加一个异常单测

@liufengwei0103
Copy link
Contributor Author

顺便加一个异常单测

已加单测

@@ -31,6 +31,28 @@ def test_dot(test_case):
z = torch.dot(x, y)
return z

def test_dot_shape_error_msg(test_case):
with test_case.assertRaises(flow._oneflow_internal.exception.Exception) as exp:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“flow._oneflow_internal.exception.Exception”改成“RuntimeException”

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

而且这个异常测试应该放到test/exceptions目录下去

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

而且这个异常测试应该放到test/exceptions目录下去

已放

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“flow._oneflow_internal.exception.Exception”改成“RuntimeException”

RuntimeError也行吧?

@liufengwei0103 liufengwei0103 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot May 9, 2022 02:19
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/8051/

@mergify mergify bot merged commit 4abe359 into master May 9, 2022
@mergify mergify bot deleted the optimize_dot_check_msg branch May 9, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants