Add oneflow.tensordot interface #7968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marigoold
requested review from
doombeaker,
jackalcooper,
hjchen2,
BBuf and
daquexian
as code owners
BBuf
reviewed
Apr 20, 2022
| @@ -659,6 +659,24 @@ def OneFlow_SiluGradOp : OneFlow_BaseOp<"silu_grad", [NoSideEffect, DeclareOpInt | |||
| let has_data_type_infer_fn = 1; | |||
| } | |||
|
|
|||
| def OneFlow_TensorDotOp : OneFlow_BaseOp<"tensordot", [NoSideEffect, DeclareOpInterfaceMethods<UserOpCompatibleInterface>]> { | |||
zhongshsh
reviewed
Apr 20, 2022
|
|
||
|
|
||
| def tensordot(a, b, dims: Union[int, List[List[int]]] = 2): | ||
| if not isinstance(dims, (oneflow._oneflow_internal.Tensor, int, list, tuple)): |
There was a problem hiding this comment.
marigoold
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
|
View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/7968/ |
|
CI failed when running job: cuda-module. PR label automerge has been removed |
Speed stats: |
|
View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/7968/ |
|
CI failed when running job: cpu-module. PR label automerge has been removed |
|
CI failed when running job: cuda-module. PR label automerge has been removed |
Speed stats: |
Speed stats: |
|
View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/7968/ |
Speed stats: |
|
View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/7968/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
此PR完成了：
算子实现的方法是在functor层，执行tensor permute -> tensor reshape -> functional::matmul -> tensor reshape的操作。
文档截图：
这里没写公式，因为我觉得那个非常难理解，而是加了一段代码的演示，告诉用户tensordot和哪一系列基本操作等价。
需要注意的地方：