-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more documentation #7849
Merged
Merged
Add more documentation #7849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjchen2
approved these changes
Mar 21, 2022
而且不少 C++ 里直接导出的方法,如果第一行不写函数原型的话,可能会导致 sphinx 自动提取的 signature 是错的(是无参无返回值的),或者很复杂(暴露内部类型) 可以参考下这个 PR:https://github.com/Oneflow-Inc/oneflow/pull/7834/files |
doombeaker
approved these changes
Mar 22, 2022
CI failed when running job: cuda-module. PR label automerge has been removed |
Speed stats:
|
Speed stats:
|
CI failed when running job: cuda-speed-test. PR label automerge has been removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list
autograd.backward ✅
autograd.autograd ✅
Tensor.grad ✅
Tensor.grad_fn ✅
Tensor.is_lazy ✅
Tensor.is_leaf ✅
Tensor.requires_grad ✅
Tensor.requires_grad_ ✅
Tensor.register_hook ✅
retain_grad ✅
Bugfix
使 pybind11 导出类的派生类可以为没有重写的方法添加文档