[Feat.] Support tensor set item in graph #7751

strint · 2022-03-10T14:36:05Z

graph中global tensor支持非var op的tesnor.set_item

mask[:, :len_keep] = 0

还有几个其它场景的支持要再完善下：

graph下，variable和activation被set item，处理方式其实不同，要考虑兼容；
- [Done]activation做的是类似ssa的inplace
- [Done]兼容eager
[Done]eager local tensor调用的flow.slice_update 改成Inplace的；

关联Issue：https://github.com/Oneflow-Inc/OneTeam/issues/1303

…flow into feat/refine_glog

hjchen2 · 2022-03-11T01:40:44Z

local tensor调用的slice update，现在行为其实不正常，需要处理成Inplace的；

local tensor调用slice update行为有什么问题么？它在调用的时候用的就是inplace的

jackalcooper · 2022-04-24T03:35:03Z

@mosout @daquexian 如果 nn graph 本身就支持了这个，是不是constant fold也可以用这些接口

…slice_assign_non_inplace

strint · 2022-04-26T00:48:59Z

local tensor调用的slice update，现在行为其实不正常，需要处理成Inplace的；

local tensor调用slice update行为有什么问题么？它在调用的时候用的就是inplace的

昨天看了下，只是 flow.slice_update 用的非inplace接口，改成inplace就好了。

hjchen2 · 2022-04-26T01:14:30Z

local tensor调用的slice update，现在行为其实不正常，需要处理成Inplace的；

local tensor调用slice update行为有什么问题么？它在调用的时候用的就是inplace的

昨天看了下，只是 flow.slice_update 用的非inplace接口，改成inplace就好了。

嗯，setitem里调用的是inplace的，这个flow.slice_update接口感觉没有必要导出到python，pytorch也没有这个接口，它完全可以用setitem来取代

mosout · 2022-04-26T09:44:11Z

@mosout @daquexian 如果 nn graph 本身就支持了这个，是不是constant fold也可以用这些接口

不是的按照目前的方案 constant folding的执行过程是纯eager的

github-actions · 2022-04-29T08:24:05Z

CI failed when running job: Build cu102_xla. PR label automerge has been removed

github-actions · 2022-04-30T01:02:55Z

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/7751/

github-actions · 2022-04-30T10:54:20Z

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/7751/

github-actions · 2022-04-30T18:46:13Z

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/7751/

github-actions · 2022-04-30T18:53:12Z

Speed stats:

github-actions · 2022-05-01T05:34:50Z

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/7751/

github-actions · 2022-05-01T06:20:10Z

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/7751/

github-actions · 2022-05-01T06:28:18Z

Speed stats:

GPU Name: GeForce GTX 1080 

✔️ OneFlow resnet50 time: 128.6ms (= 12863.2ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 142.3ms (= 14229.8ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.11 (= 142.3ms / 128.6ms)

OneFlow resnet50 time: 78.3ms (= 7829.7ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 84.7ms (= 8468.4ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.08 (= 84.7ms / 78.3ms)

OneFlow resnet50 time: 53.4ms (= 10687.7ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 58.9ms (= 11784.2ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.10 (= 58.9ms / 53.4ms)

OneFlow resnet50 time: 41.7ms (= 8344.2ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 40.1ms (= 8012.1ms / 200, input_shape=[2, 3, 224, 224])
❌ Relative speed: 0.96 (= 40.1ms / 41.7ms)

OneFlow resnet50 time: 39.1ms (= 7827.0ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 41.5ms (= 8300.4ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.06 (= 41.5ms / 39.1ms)

OneFlow swin dataloader time: 0.258s (= 51.537s / 200, num_workers=1)
PyTorch swin dataloader time: 0.150s (= 30.082s / 200, num_workers=1)
Relative speed: 0.584 (= 0.150s / 0.258s)

OneFlow swin dataloader time: 0.071s (= 14.147s / 200, num_workers=4)
PyTorch swin dataloader time: 0.042s (= 8.464s / 200, num_workers=4)
Relative speed: 0.598 (= 0.042s / 0.071s)

OneFlow swin dataloader time: 0.037s (= 7.333s / 200, num_workers=8)
PyTorch swin dataloader time: 0.022s (= 4.457s / 200, num_workers=8)
Relative speed: 0.608 (= 0.022s / 0.037s)

✔️ OneFlow resnet50 time: 135.6ms (= 13563.4ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 160.5ms (= 16054.6ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.18 (= 160.5ms / 135.6ms)

OneFlow resnet50 time: 89.1ms (= 8909.9ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 100.1ms (= 10005.5ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.12 (= 100.1ms / 89.1ms)

OneFlow resnet50 time: 65.9ms (= 13180.2ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 77.4ms (= 15471.2ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
❌ Relative speed: 1.17 (= 77.4ms / 65.9ms)

OneFlow resnet50 time: 50.9ms (= 10182.6ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 69.2ms (= 13848.8ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.36 (= 69.2ms / 50.9ms)

OneFlow resnet50 time: 52.3ms (= 10454.3ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 74.6ms (= 14913.6ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.43 (= 74.6ms / 52.3ms)

github-actions · 2022-05-01T12:21:36Z

Speed stats:

github-actions · 2022-05-01T14:04:13Z

Speed stats:

github-actions · 2022-05-01T15:24:25Z

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/7751/

github-actions · 2022-05-01T20:42:47Z

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/7751/

strint and others added 13 commits March 3, 2022 12:56

refine log level

35936f2

format

7086de9

refine log level

b7bf109

Merge branch 'master' into feat/refine_glog

87ae7cc

auto format by CI

1ddcc9b

refine from review

b7f0752

Merge branch 'feat/refine_glog' of https://github.com/Oneflow-Inc/one…

fe643d7

…flow into feat/refine_glog

auto format by CI

f95f5d6

revert useless code

42deec3

Merge branch 'feat/refine_glog' of https://github.com/Oneflow-Inc/one…

2d85225

…flow into feat/refine_glog

add test

fef2d86

merge

e2870e5

add slice assign out

a2e89c3

strint changed the title ~~Slice assign for graph~~ tensor set item for graph Mar 10, 2022

Merge branch 'master' into slice_assign_non_inplace

a8a0dbf

strint added 3 commits April 25, 2022 11:35

Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow into …

dbef328

…slice_assign_non_inplace

add test

68f9bb0

pass tests

0cd4081

add backword test

c2bee23

strint added 3 commits April 26, 2022 20:40

add slic test; add to_graph

b1453a9

finish test

fbbd2c4

fix typo

38379a0

strint marked this pull request as ready for review April 27, 2022 02:48

strint requested review from hjchen2 and BBuf as code owners April 27, 2022 02:48

strint added the automerge label Apr 29, 2022

strint requested a review from oneflow-ci-bot April 29, 2022 08:21

github-actions bot removed the automerge label Apr 29, 2022

Merge branch 'master' into slice_assign_non_inplace

f63beb2

strint added the automerge label Apr 29, 2022

Merge branch 'master' into slice_assign_non_inplace

ec673ad

mergify bot added 3 commits April 30, 2022 12:31

Merge branch 'master' into slice_assign_non_inplace

d9e9fcd

Merge branch 'master' into slice_assign_non_inplace

dffd187

Merge branch 'master' into slice_assign_non_inplace

7d1a483

strint and others added 2 commits May 1, 2022 09:51

fix doc test

3e71245

Merge branch 'master' into slice_assign_non_inplace

03f3b80

Merge branch 'master' into slice_assign_non_inplace

159a11e

mergify bot added 2 commits May 1, 2022 10:55

Merge branch 'master' into slice_assign_non_inplace

12b175e

Merge branch 'master' into slice_assign_non_inplace

3741c98

Merge branch 'master' into slice_assign_non_inplace

17161ba

Merge branch 'master' into slice_assign_non_inplace

3cc5e76

mergify bot merged commit b3f84bb into master May 1, 2022

mergify bot deleted the slice_assign_non_inplace branch May 1, 2022 21:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feat.] Support tensor set item in graph #7751

[Feat.] Support tensor set item in graph #7751

strint commented Mar 10, 2022 •

edited

Loading

hjchen2 commented Mar 11, 2022

jackalcooper commented Apr 24, 2022

strint commented Apr 26, 2022

hjchen2 commented Apr 26, 2022 •

edited

Loading

mosout commented Apr 26, 2022

github-actions bot commented Apr 29, 2022

github-actions bot commented Apr 30, 2022

github-actions bot commented Apr 30, 2022

github-actions bot commented Apr 30, 2022

github-actions bot commented Apr 30, 2022

github-actions bot commented May 1, 2022

github-actions bot commented May 1, 2022

github-actions bot commented May 1, 2022

github-actions bot commented May 1, 2022

github-actions bot commented May 1, 2022

github-actions bot commented May 1, 2022

github-actions bot commented May 1, 2022

[Feat.] Support tensor set item in graph #7751

[Feat.] Support tensor set item in graph #7751

Conversation

strint commented Mar 10, 2022 • edited Loading

hjchen2 commented Mar 11, 2022

jackalcooper commented Apr 24, 2022

strint commented Apr 26, 2022

hjchen2 commented Apr 26, 2022 • edited Loading

mosout commented Apr 26, 2022

github-actions bot commented Apr 29, 2022

github-actions bot commented Apr 30, 2022

github-actions bot commented Apr 30, 2022

github-actions bot commented Apr 30, 2022

github-actions bot commented Apr 30, 2022

github-actions bot commented May 1, 2022

github-actions bot commented May 1, 2022

github-actions bot commented May 1, 2022

github-actions bot commented May 1, 2022

github-actions bot commented May 1, 2022

github-actions bot commented May 1, 2022

github-actions bot commented May 1, 2022

strint commented Mar 10, 2022 •

edited

Loading

hjchen2 commented Apr 26, 2022 •

edited

Loading