Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add eager test case, fix origin error cases #7421

Merged
merged 28 commits into from
Feb 25, 2022
Merged

add eager test case, fix origin error cases #7421

merged 28 commits into from
Feb 25, 2022

Conversation

wyushun
Copy link
Contributor

@wyushun wyushun commented Feb 6, 2022

No description provided.

@wyushun wyushun requested review from hjchen2 and wyg1997 February 6, 2022 03:32
@wyushun wyushun self-assigned this Feb 6, 2022
@wyushun wyushun force-pushed the wyushun_eager_auto_test branch from b2deda4 to 76d4f2c Compare February 24, 2022 06:15
@wyushun wyushun changed the title [WIP]add eager test case, fix origin error cases add eager test case, fix origin error cases Feb 24, 2022
@github-actions
Copy link
Contributor

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@wyushun wyushun requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 24, 2022 09:10
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 24, 2022 14:10
@github-actions
Copy link
Contributor

CI failed when running job: cuda-module-distributed-rank-0. PR label automerge has been removed

@oneflow-ci-bot oneflow-ci-bot removed their request for review February 24, 2022 14:32
@hjchen2 hjchen2 enabled auto-merge (squash) February 25, 2022 02:09
@oneflow-ci-bot oneflow-ci-bot removed their request for review February 25, 2022 02:23
@oneflow-ci-bot oneflow-ci-bot self-requested a review February 25, 2022 02:23
@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 

✔️ OneFlow resnet50 time: 128.8ms (= 12884.4ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 140.2ms (= 14021.6ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.09 (= 140.2ms / 128.8ms)

✔️ OneFlow resnet50 time: 76.7ms (= 7670.4ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 85.5ms (= 8545.8ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.11 (= 85.5ms / 76.7ms)

OneFlow resnet50 time: 53.4ms (= 10671.2ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 56.0ms (= 11201.9ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.05 (= 56.0ms / 53.4ms)

OneFlow resnet50 time: 43.2ms (= 8636.8ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 47.3ms (= 9454.0ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.09 (= 47.3ms / 43.2ms)

OneFlow resnet50 time: 38.9ms (= 7787.3ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 38.4ms (= 7672.4ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 0.99 (= 38.4ms / 38.9ms)

✔️ OneFlow resnet50 time: 142.2ms (= 14224.9ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 159.6ms (= 15955.8ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.12 (= 159.6ms / 142.2ms)

OneFlow resnet50 time: 89.2ms (= 8922.3ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 102.4ms (= 10235.4ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.15 (= 102.4ms / 89.2ms)

OneFlow resnet50 time: 63.2ms (= 12641.5ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 76.4ms (= 15272.2ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.21 (= 76.4ms / 63.2ms)

OneFlow resnet50 time: 53.9ms (= 10770.0ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 66.6ms (= 13317.9ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.24 (= 66.6ms / 53.9ms)

OneFlow resnet50 time: 49.0ms (= 9801.3ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 62.8ms (= 12567.6ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.28 (= 62.8ms / 49.0ms)

@wyushun wyushun requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 25, 2022 03:33
@oneflow-ci-bot oneflow-ci-bot removed their request for review February 25, 2022 03:36
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 25, 2022 07:29
@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 

✔️ OneFlow resnet50 time: 128.6ms (= 12861.2ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 142.7ms (= 14267.1ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.11 (= 142.7ms / 128.6ms)

✔️ OneFlow resnet50 time: 78.7ms (= 7866.9ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 87.6ms (= 8760.5ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.11 (= 87.6ms / 78.7ms)

OneFlow resnet50 time: 53.6ms (= 10728.2ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 61.5ms (= 12305.2ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.15 (= 61.5ms / 53.6ms)

OneFlow resnet50 time: 44.6ms (= 8927.7ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 46.3ms (= 9263.5ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.04 (= 46.3ms / 44.6ms)

OneFlow resnet50 time: 36.8ms (= 7363.9ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 41.7ms (= 8347.1ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.13 (= 41.7ms / 36.8ms)

✔️ OneFlow resnet50 time: 142.6ms (= 14261.4ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 160.6ms (= 16057.2ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.13 (= 160.6ms / 142.6ms)

OneFlow resnet50 time: 91.4ms (= 9141.3ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 100.6ms (= 10064.5ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.10 (= 100.6ms / 91.4ms)

OneFlow resnet50 time: 63.5ms (= 12706.4ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 71.8ms (= 14355.8ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.13 (= 71.8ms / 63.5ms)

OneFlow resnet50 time: 53.7ms (= 10732.8ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 65.6ms (= 13117.1ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.22 (= 65.6ms / 53.7ms)

OneFlow resnet50 time: 48.1ms (= 9614.1ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 62.0ms (= 12403.2ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.29 (= 62.0ms / 48.1ms)

@hjchen2 hjchen2 merged commit 9b2455e into master Feb 25, 2022
@hjchen2 hjchen2 deleted the wyushun_eager_auto_test branch February 25, 2022 09:19
marigoold pushed a commit that referenced this pull request Mar 15, 2022
@wyushun @oneflow-ci-bot
@hjchen2 @marigoold
add eager test case, fix origin error cases (#7421)
bc0c944 
* add test_consistent_erfc.py

* add test_consistent_eye.py, it has error now

* update test_consistent_eye.py

* add test_consistent_empty.py

* add three todo test cases

* update

* update

* add test_consistent_dot.py

* add test_consistent_diag.py

* add test_consistent_div.py

* add test_consistent_eq.py

* add test_consistent_erf.py

* add test_consistent_expm1.py

* add test_consistent_flatten.py

* add test_consistent_floor/fmod/greater_equal files

* update

* open check graph

* auto format by CI

* Revert "open check graph"

This reverts commit 79e72a6.

* update

* update

* Update python/oneflow/test/modules/test_consistent_flatten.py

Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
Co-authored-by: Houjiang Chen <chenhoujiangcug@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjchen2 hjchen2 hjchen2 approved these changes

@clackhan clackhan clackhan approved these changes

@wyg1997 wyg1997 Awaiting requested review from wyg1997

@daquexian daquexian Awaiting requested review from daquexian

@jackalcooper jackalcooper Awaiting requested review from jackalcooper

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

Assignees

@wyushun wyushun

Labels
automerge eager enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wyushun @hjchen2 @clackhan @oneflow-ci-bot