Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consistent_tensor_scatter_nd_update_test #7308

Merged
merged 85 commits into from
Mar 2, 2022
Merged

consistent_tensor_scatter_nd_update_test #7308

merged 85 commits into from
Mar 2, 2022

Conversation

clackhan
Copy link
Contributor

添加 tensor_scatter_nd_update consistent 测试

hjchen2 and others added 30 commits January 5, 2022 18:42
@hjchen2
add doc for pybind type
1743bf0
@hjchen2
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow
b1ff4b2
@hjchen2
eager consistent autotest
31359f1
@hjchen2
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow into …
93aaed9 
…dev_eager_consistent_auto_test
@hjchen2
align placement repr and api
68534be
@hjchen2
export necessary apis to pickle object
4fc1196
@hjchen2
broadcast rank 0 to other rank if consistent test
d191ce6
@hjchen2
update consistent add unittest
4077b86
@hjchen2
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow into …
af19043 
…dev_eager_consistent_auto_test
@hjchen2
refine
3c30177
@hjchen2
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow into …
ce63e4f 
…dev_eager_consistent_auto_test
@hjchen2
Merge branch 'master' into dev_eager_consistent_auto_test
355e251
@hjchen2
add concat tests
3fc646f
@hjchen2
Merge branch 'dev_eager_consistent_auto_test' of https://github.com/O…
198368c 
…neflow-Inc/oneflow into dev_eager_consistent_auto_test
@hjchen2
Merge branch 'master' into dev_eager_consistent_auto_test
93f7bb7
@oneflow-ci-bot
Merge branch 'master' into dev_eager_consistent_auto_test
23220f3
@hjchen2
Merge branch 'master' into dev_eager_consistent_auto_test
dfa286d
@hjchen2
refine
4fe7c9e
@hjchen2
Merge branch 'dev_eager_consistent_auto_test' of https://github.com/O…
84e7f00 
…neflow-Inc/oneflow into dev_eager_consistent_auto_test
@hjchen2
Merge branch 'master' into dev_eager_consistent_auto_test
d4e686c
@oneflow-ci-bot
Merge branch 'master' into dev_eager_consistent_auto_test
7c57e20
@oneflow-ci-bot
Merge branch 'master' into dev_eager_consistent_auto_test
9fcbd8c
@hjchen2
refine
3a2b9d0
@oneflow-ci-bot
Merge branch 'master' into dev_eager_consistent_auto_test
d9b2e37
@hjchen2
use larger dim size
a89d133
@hjchen2
Merge branch 'dev_eager_consistent_auto_test' of https://github.com/O…
d9b82de 
…neflow-Inc/oneflow into dev_eager_consistent_auto_test
@oneflow-ci-bot
Merge branch 'master' into dev_eager_consistent_auto_test
a02b954
@oneflow-ci-bot
Merge branch 'master' into dev_eager_consistent_auto_test
aaa457c
@oneflow-ci-bot
Merge branch 'master' into dev_eager_consistent_auto_test
97eb854
@oneflow-ci-bot
Merge branch 'master' into dev_eager_consistent_auto_test
9aac591
@clackhan clackhan requested a review from oneflow-ci-bot March 1, 2022 04:22
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022

CI failed when running job: cuda-module-distributed-rank-1. PR label automerge has been removed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022

CI failed when running job: cuda-module-distributed-rank-0. PR label automerge has been removed

@github-actions github-actions bot removed the automerge label Mar 1, 2022
@oneflow-ci-bot oneflow-ci-bot removed their request for review March 1, 2022 06:00
@clackhan clackhan requested a review from oneflow-ci-bot March 1, 2022 08:33
@oneflow-ci-bot oneflow-ci-bot removed their request for review March 1, 2022 08:48
@oneflow-ci-bot oneflow-ci-bot self-requested a review March 1, 2022 10:54
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022

CI failed when running job: cuda-module-distributed-rank-0. PR label automerge has been removed

@github-actions github-actions bot removed the automerge label Mar 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022

CI failed when running job: cuda-module-distributed-rank-1. PR label automerge has been removed

@clackhan clackhan requested review from oneflow-ci-bot and removed request for oneflow-ci-bot March 2, 2022 01:42
@oneflow-ci-bot oneflow-ci-bot removed their request for review March 2, 2022 01:59
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2022

Speed stats: 
GPU Name: GeForce GTX 1080 

✔️ OneFlow resnet50 time: 128.7ms (= 12866.6ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 140.2ms (= 14022.7ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.09 (= 140.2ms / 128.7ms)

✔️ OneFlow resnet50 time: 77.3ms (= 7725.1ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 86.1ms (= 8614.7ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.12 (= 86.1ms / 77.3ms)

OneFlow resnet50 time: 53.9ms (= 10775.2ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 55.3ms (= 11064.0ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.03 (= 55.3ms / 53.9ms)

OneFlow resnet50 time: 43.3ms (= 8667.3ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 46.0ms (= 9209.0ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.06 (= 46.0ms / 43.3ms)

OneFlow resnet50 time: 35.9ms (= 7179.8ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 37.6ms (= 7521.8ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.05 (= 37.6ms / 35.9ms)

✔️ OneFlow resnet50 time: 142.3ms (= 14225.9ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 164.2ms (= 16420.0ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.15 (= 164.2ms / 142.3ms)

OneFlow resnet50 time: 89.7ms (= 8968.5ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 106.5ms (= 10646.6ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.19 (= 106.5ms / 89.7ms)

OneFlow resnet50 time: 61.2ms (= 12248.4ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 74.6ms (= 14910.6ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.22 (= 74.6ms / 61.2ms)

OneFlow resnet50 time: 52.2ms (= 10438.3ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 68.7ms (= 13734.7ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.32 (= 68.7ms / 52.2ms)

OneFlow resnet50 time: 48.7ms (= 9746.5ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 60.3ms (= 12069.3ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.24 (= 60.3ms / 48.7ms)

@oneflow-ci-bot oneflow-ci-bot merged commit a2a367d into master Mar 2, 2022
@oneflow-ci-bot oneflow-ci-bot deleted the consistent_tensor_scatter_nd_update_test branch March 2, 2022 04:15
marigoold pushed a commit that referenced this pull request Mar 15, 2022
@clackhan @hjchen2
@oneflow-ci-bot @marigoold
consistent_tensor_scatter_nd_update_test (#7308)
b0b08a3 
* add doc for pybind type

* eager consistent autotest

* align placement repr and api

* export necessary apis to pickle object

* broadcast rank 0 to other rank if consistent test

* update consistent add unittest

* refine

* add concat tests

* refine

* refine

* use larger dim size

* fix autotest

* fix

* fix

* consistent_tensor_scatter_nd_update_test

* fix merge error

* minor fix

* rename global_view

* auto format by CI

* refine

* add choice generator

* refine

* add note

* Update test_consistent_tensor_scatter_nd_update.py

* fix bug

* skip lazy test

Co-authored-by: hjchen2 <chenhoujiangcug@gmail.com>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org>
wyg1997 pushed a commit that referenced this pull request Mar 17, 2022
@clackhan @hjchen2
@oneflow-ci-bot @wyg1997
consistent_tensor_scatter_nd_update_test (#7308)
1369912 
* add doc for pybind type

* eager consistent autotest

* align placement repr and api

* export necessary apis to pickle object

* broadcast rank 0 to other rank if consistent test

* update consistent add unittest

* refine

* add concat tests

* refine

* refine

* use larger dim size

* fix autotest

* fix

* fix

* consistent_tensor_scatter_nd_update_test

* fix merge error

* minor fix

* rename global_view

* auto format by CI

* refine

* add choice generator

* refine

* add note

* Update test_consistent_tensor_scatter_nd_update.py

* fix bug

* skip lazy test

Co-authored-by: hjchen2 <chenhoujiangcug@gmail.com>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjchen2 hjchen2 hjchen2 approved these changes

@wyg1997 wyg1997 wyg1997 approved these changes

Assignees
No one assigned
Labels
automerge enhancement system test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clackhan @hjchen2 @wyg1997 @jackalcooper @oneflow-ci-bot