Dev eliminate gcc warnings #6199

Flowingsun007 · 2021-09-08T01:26:34Z

此pr修复了5条oneflow编译时gcc给出的warning

/home/luyang/Oneflow/oneflow/oneflow/user/kernels/nvtx_range_kernel.cu(62): warning: variable "kernel_state" was declared but never referenced

/home/luyang/Oneflow/oneflow/oneflow/user/kernels/nvtx_range_kernel.cu(104): warning: variable "kernel_state" was declared but never referenced


/home/luyang/Oneflow/oneflow/oneflow/core/framework/op_interpreter/boxing/symmetric_nd_sbp_boxing.cpp: In function ‘oneflow::Maybe<oneflow::one::Tensor> oneflow::SymmetricNdSbpBoxing(const std::shared_ptr<oneflow::one::Tensor>&, oneflow::Symbol<oneflow::PlacedNdSbp>, oneflow::Symbol<oneflow::PlacedNdSbp>)’:
/home/luyang/Oneflow/oneflow/oneflow/core/framework/op_interpreter/boxing/symmetric_nd_sbp_boxing.cpp:74:15: warning: unused variable ‘in_nd_sbp’ [-Wunused-variable]
   const auto& in_nd_sbp = in->nd_sbp();
               ^~~~~~~~~

/home/luyang/Oneflow/oneflow/oneflow/core/job/session_global_objects_scope.cpp: In function ‘oneflow::AvailableMemDesc oneflow::{anonymous}::GetDryRunAvailableMemDesc()’:
/home/luyang/Oneflow/oneflow/oneflow/core/job/session_global_objects_scope.cpp:94:16: warning: unused variable ‘i’ [-Wunused-variable]
   for (int64_t i : Global<ResourceDesc, ForSession>::Get()->process_ranks()) {
                ^


/home/luyang/Oneflow/oneflow/oneflow/user/ops/narrow_op.cpp: In lambda function:
/home/luyang/Oneflow/oneflow/oneflow/user/ops/narrow_op.cpp:50:22: warning: unused variable ‘start’ [-Wunused-variable]
       const int64_t& start = ctx->Attr<int64_t>("start");
                      ^~~~~

/home/luyang/Oneflow/oneflow/oneflow/user/ops/prelu_op.cpp: In lambda function:
/home/luyang/Oneflow/oneflow/oneflow/user/ops/prelu_op.cpp:75:34: warning: unused variable ‘alpha_tensor’ [-Wunused-variable]
       const user_op::TensorDesc& alpha_tensor =
                                  ^~~~~~~~~~~~

liujuncheng · 2021-09-08T01:40:40Z

oneflow/core/kernel/user_kernel.cpp

 #ifdef WITH_CUDA_GRAPHS
+  const bool updated = ctx_->UpdateTensorWithCorrBlob(BnInOp2Blob);


这个方法是有副作用的，不能移动到宏里边

好的，那我恢复吧

github-actions · 2021-09-08T11:51:20Z

Speed stats:

GPU Name: GeForce GTX 1080 

OneFlow resnet50 time: 128.6ms (= 6428.1ms / 50, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 141.1ms (= 7056.8ms / 50, input_shape=[16, 3, 224, 224])
Relative speed: 1.10 (= 141.1ms / 128.6ms)

OneFlow resnet50 time: 74.6ms (= 3728.9ms / 50, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 84.5ms (= 4223.4ms / 50, input_shape=[8, 3, 224, 224])
Relative speed: 1.13 (= 84.5ms / 74.6ms)

OneFlow resnet50 time: 47.7ms (= 2386.7ms / 50, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 58.9ms (= 2942.9ms / 50, input_shape=[4, 3, 224, 224])
Relative speed: 1.23 (= 58.9ms / 47.7ms)

OneFlow resnet50 time: 41.9ms (= 2093.0ms / 50, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 47.3ms (= 2367.3ms / 50, input_shape=[2, 3, 224, 224])
Relative speed: 1.13 (= 47.3ms / 41.9ms)

OneFlow resnet50 time: 42.5ms (= 2123.6ms / 50, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 45.2ms (= 2261.4ms / 50, input_shape=[1, 3, 224, 224])
Relative speed: 1.06 (= 45.2ms / 42.5ms)

OneFlow resnet50 time: 154.4ms (= 7722.0ms / 50, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 154.8ms (= 7740.1ms / 50, input_shape=[16, 3, 224, 224], ddp, world size=2)
Relative speed: 1.00 (= 154.8ms / 154.4ms)

OneFlow resnet50 time: 102.7ms (= 5134.7ms / 50, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 99.8ms (= 4990.0ms / 50, input_shape=[8, 3, 224, 224], ddp, world size=2)
Relative speed: 0.97 (= 99.8ms / 102.7ms)

OneFlow resnet50 time: 81.3ms (= 4062.7ms / 50, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 72.9ms (= 3642.5ms / 50, input_shape=[4, 3, 224, 224], ddp, world size=2)
Relative speed: 0.90 (= 72.9ms / 81.3ms)

OneFlow resnet50 time: 66.5ms (= 3323.4ms / 50, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 65.5ms (= 3276.8ms / 50, input_shape=[2, 3, 224, 224], ddp, world size=2)
Relative speed: 0.99 (= 65.5ms / 66.5ms)

OneFlow resnet50 time: 68.2ms (= 3407.7ms / 50, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 61.4ms (= 3068.1ms / 50, input_shape=[1, 3, 224, 224], ddp, world size=2)
Relative speed: 0.90 (= 61.4ms / 68.2ms)

jackalcooper · 2021-09-08T11:52:43Z

oneflow/core/job/session_global_objects_scope.cpp

@@ -91,7 +91,7 @@ AvailableMemDesc GetDryRunAvailableMemDesc() {

  AvailableMemDesc ret;
  AvailableMemDescOfMachine machine_amd_i;
-  for (int64_t i : Global<ResourceDesc, ForSession>::Get()->process_ranks()) {
+  for (int64_t i = 0; i < Global<ResourceDesc, ForSession>::Get()->process_ranks().size(); ++i) {


这两个不一定等价？

* Primitive (#6183) * Add Primitive * #ifdef WITH_CUDA Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Disable implicit boxing when parallel num eq one (#6188) * mv_boxing_folder_to_core * minor fix * disable_implicit_boxing_when_parallel_num_eq_one * Update eager_consistent_op_interpreter.cpp Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Lazy support Scalar (#6181) Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Fix LayerNorm check bug (#6196) * fix(Layernorm): fix check bug * fix judge whether cpu or not Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * add glu op (#6065) * add glu op * del glu_op export，align with torch * mod glu_op * mov op logic to C++ * Solve problems * solve conflict * delete gradient functor * add ndim check * add GLU test * delete blank line * format Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> Co-authored-by: Zhenhua <huangzhenhua@zhejianglab.com> * Primitive based copy task node (#6195) Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * KernelState (#6198) Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * container_util: fix VectorAt, remove useless MutMapAt (#6172) * fcontainer_util: fix VectorAt, remove useless MutMapAt * fcontainer_util: format * MapAt: add default value version * format Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Refine StreamContext (#6191) Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Cpu symetric s to s (#6153) * mv_boxing_folder_to_core * minor fix * cpu_symetric_s_to_s * add test case * auto format by CI * minor fix * refine * Update eager_nccl_kernels.cpp * minor fix * fix bug * minor fix * Update oneflow/user/kernels/eager_nccl_kernels.cpp Co-authored-by: daquexian <daquexian566@gmail.com> * Update eager_nccl_kernels.cpp * Update eager_nccl_kernels.cpp * minor fix * Update eager_nccl_kernels.cpp Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org> Co-authored-by: daquexian <daquexian566@gmail.com> * fix bug (#6197) Co-authored-by: Yinggang Wang <wyg19970408@gmail.com> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * fix consistent tensor zeros (#6202) Signed-off-by: daquexian <daquexian566@gmail.com> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * [Feat.] nn.Graph support grad acc with input/output tensor (#6155) * nn.Graph support grad acc with input/output tensor * dirty pass grad acc * revert tensor.backward hack * fix indent * default S0 -> B * Pack op/kernel support scalar input * nn.Graph output pack support loss scalar * add test script * pass test * Lazy build output eager tensors after job complete * non scalar output test Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Dev eliminate gcc warnings (#6199) * fix gcc warning * refine * fix comment Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * StreamContextAdapter (#6205) * StreamContextAdapter * refine Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Autotest generate input tensor (#6206) * Add tensor yaml, support export tensor functional api. * refine * Remove packed functor signature * remove unused file * Refine * refine * add activation op import * reinit oneflow init.py * add oneflow abs and exp * add oneflow abs and exp * add acos * add arccosh * add more op * add more ops * add more op * add more ops * add log1p * add more smaples * add more ops * add more ops * add more ops * add more ops * Complete tensor functional apis. * Fix pybind call * add more ops * add ops done * Add target of_functional_tensor_obj * Disable throw visibility warnings * fix target link * fix * fix incorrect use of flow.Tensor. * Fix error merge * fix * fix add unittest * refine * refine * fix * fix * add tensor doc * auto format by CI * refine * Fix * Add doc for python function * refine * add tensor method docstring * fix some bug * fix docs bug * Fix * auto format by CI * Tensor->tensor * Tensor->tensor * refine Tensor->tensor * fix * fix * fix * fix conflict * fix bug * fix ci bug * fix * delete diag op * fix conflict * Fix segment * fix * merge * autotest framework generate input tensor * autotest framework generate input tensor * fix bug * fix impl bug * refine * refine * refine * fix * fix * fix comments * delete useless * fix ci error * fix ci error Co-authored-by: hjchen2 <chenhoujiangcug@gmail.com> Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Cleanup KernelUtil (#6212) Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Rename flow to oneflow in user hint (#6190) * style(*): rename flow to oneflow in user hint * fix(*): fix doctest * auto format by CI * remove ddp speed test Signed-off-by: daquexian <daquexian566@gmail.com> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org> Co-authored-by: daquexian <daquexian566@gmail.com> * merg and refactor * refact code * add io identity for activation checkpointing Co-authored-by: Juncheng <liujuncheng1022@gmail.com> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> Co-authored-by: binbinHan <han_binbin@163.com> Co-authored-by: cheng cheng <472491134@qq.com> Co-authored-by: Yinggang Wang <wyg19970408@gmail.com> Co-authored-by: QiangX-man <87475073+QiangX-man@users.noreply.github.com> Co-authored-by: Zhenhua <huangzhenhua@zhejianglab.com> Co-authored-by: Twice <i@twice.moe> Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org> Co-authored-by: daquexian <daquexian566@gmail.com> Co-authored-by: ZZK <42901638+MARD1NO@users.noreply.github.com> Co-authored-by: Luyang <flowingsun007@163.com> Co-authored-by: Xiaoyu Zhang <35585791+BBuf@users.noreply.github.com> Co-authored-by: hjchen2 <chenhoujiangcug@gmail.com>

* Add test_graph_activation_checkpoint.py * Fea/checkpoint stop identity (#6216) * Primitive (#6183) * Add Primitive * #ifdef WITH_CUDA Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Disable implicit boxing when parallel num eq one (#6188) * mv_boxing_folder_to_core * minor fix * disable_implicit_boxing_when_parallel_num_eq_one * Update eager_consistent_op_interpreter.cpp Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Lazy support Scalar (#6181) Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Fix LayerNorm check bug (#6196) * fix(Layernorm): fix check bug * fix judge whether cpu or not Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * add glu op (#6065) * add glu op * del glu_op export，align with torch * mod glu_op * mov op logic to C++ * Solve problems * solve conflict * delete gradient functor * add ndim check * add GLU test * delete blank line * format Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> Co-authored-by: Zhenhua <huangzhenhua@zhejianglab.com> * Primitive based copy task node (#6195) Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * KernelState (#6198) Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * container_util: fix VectorAt, remove useless MutMapAt (#6172) * fcontainer_util: fix VectorAt, remove useless MutMapAt * fcontainer_util: format * MapAt: add default value version * format Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Refine StreamContext (#6191) Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Cpu symetric s to s (#6153) * mv_boxing_folder_to_core * minor fix * cpu_symetric_s_to_s * add test case * auto format by CI * minor fix * refine * Update eager_nccl_kernels.cpp * minor fix * fix bug * minor fix * Update oneflow/user/kernels/eager_nccl_kernels.cpp Co-authored-by: daquexian <daquexian566@gmail.com> * Update eager_nccl_kernels.cpp * Update eager_nccl_kernels.cpp * minor fix * Update eager_nccl_kernels.cpp Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org> Co-authored-by: daquexian <daquexian566@gmail.com> * fix bug (#6197) Co-authored-by: Yinggang Wang <wyg19970408@gmail.com> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * fix consistent tensor zeros (#6202) Signed-off-by: daquexian <daquexian566@gmail.com> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * [Feat.] nn.Graph support grad acc with input/output tensor (#6155) * nn.Graph support grad acc with input/output tensor * dirty pass grad acc * revert tensor.backward hack * fix indent * default S0 -> B * Pack op/kernel support scalar input * nn.Graph output pack support loss scalar * add test script * pass test * Lazy build output eager tensors after job complete * non scalar output test Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Dev eliminate gcc warnings (#6199) * fix gcc warning * refine * fix comment Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * StreamContextAdapter (#6205) * StreamContextAdapter * refine Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Autotest generate input tensor (#6206) * Add tensor yaml, support export tensor functional api. * refine * Remove packed functor signature * remove unused file * Refine * refine * add activation op import * reinit oneflow init.py * add oneflow abs and exp * add oneflow abs and exp * add acos * add arccosh * add more op * add more ops * add more op * add more ops * add log1p * add more smaples * add more ops * add more ops * add more ops * add more ops * Complete tensor functional apis. * Fix pybind call * add more ops * add ops done * Add target of_functional_tensor_obj * Disable throw visibility warnings * fix target link * fix * fix incorrect use of flow.Tensor. * Fix error merge * fix * fix add unittest * refine * refine * fix * fix * add tensor doc * auto format by CI * refine * Fix * Add doc for python function * refine * add tensor method docstring * fix some bug * fix docs bug * Fix * auto format by CI * Tensor->tensor * Tensor->tensor * refine Tensor->tensor * fix * fix * fix * fix conflict * fix bug * fix ci bug * fix * delete diag op * fix conflict * Fix segment * fix * merge * autotest framework generate input tensor * autotest framework generate input tensor * fix bug * fix impl bug * refine * refine * refine * fix * fix * fix comments * delete useless * fix ci error * fix ci error Co-authored-by: hjchen2 <chenhoujiangcug@gmail.com> Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Cleanup KernelUtil (#6212) Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Rename flow to oneflow in user hint (#6190) * style(*): rename flow to oneflow in user hint * fix(*): fix doctest * auto format by CI * remove ddp speed test Signed-off-by: daquexian <daquexian566@gmail.com> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org> Co-authored-by: daquexian <daquexian566@gmail.com> * merg and refactor * refact code * add io identity for activation checkpointing Co-authored-by: Juncheng <liujuncheng1022@gmail.com> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> Co-authored-by: binbinHan <han_binbin@163.com> Co-authored-by: cheng cheng <472491134@qq.com> Co-authored-by: Yinggang Wang <wyg19970408@gmail.com> Co-authored-by: QiangX-man <87475073+QiangX-man@users.noreply.github.com> Co-authored-by: Zhenhua <huangzhenhua@zhejianglab.com> Co-authored-by: Twice <i@twice.moe> Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org> Co-authored-by: daquexian <daquexian566@gmail.com> Co-authored-by: ZZK <42901638+MARD1NO@users.noreply.github.com> Co-authored-by: Luyang <flowingsun007@163.com> Co-authored-by: Xiaoyu Zhang <35585791+BBuf@users.noreply.github.com> Co-authored-by: hjchen2 <chenhoujiangcug@gmail.com> * rm useless code * refien test * add skip * import os * fix test * auto format by CI Co-authored-by: strint <xiaoyulink@gmail.com> Co-authored-by: Juncheng <liujuncheng1022@gmail.com> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> Co-authored-by: binbinHan <han_binbin@163.com> Co-authored-by: cheng cheng <472491134@qq.com> Co-authored-by: Yinggang Wang <wyg19970408@gmail.com> Co-authored-by: QiangX-man <87475073+QiangX-man@users.noreply.github.com> Co-authored-by: Zhenhua <huangzhenhua@zhejianglab.com> Co-authored-by: Twice <i@twice.moe> Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org> Co-authored-by: daquexian <daquexian566@gmail.com> Co-authored-by: ZZK <42901638+MARD1NO@users.noreply.github.com> Co-authored-by: Luyang <flowingsun007@163.com> Co-authored-by: Xiaoyu Zhang <35585791+BBuf@users.noreply.github.com> Co-authored-by: hjchen2 <chenhoujiangcug@gmail.com>

* add demo * add test draft * debug pipeline graph * add pp * add * support 0-d tensor spilt * add repr of conf for debug * add acc grad * add tag * hack stage id of to_consistent * Pipeline buffer pass stage id check log * FixPipelineStageIdPass interface * nn.Graph support grad acc with input/output tensor * dirty pass grad acc * Lazy support Scalar * add log * revert tensor.backward hack * fix indent * default S0 -> B * merge * Pack op/kernel support scalar input * nn.Graph output pack support loss scalar * add test script * add pack * pass test * Add test_graph_activation_checkpoint.py * Lazy build output eager tensors after job complete * non scalar output test * stale input * add debug * add * add test * add test * deal with empty kernel of_record tensor buffer * add test * refine test * New scope by stage id * rm debug log * finish test * half impl of stage id infer * Fix pipeline stage id by close max group * remove note * remove debug code * Fea/checkpoint stop identity (#6216) * Primitive (#6183) * Add Primitive * #ifdef WITH_CUDA Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Disable implicit boxing when parallel num eq one (#6188) * mv_boxing_folder_to_core * minor fix * disable_implicit_boxing_when_parallel_num_eq_one * Update eager_consistent_op_interpreter.cpp Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Lazy support Scalar (#6181) Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Fix LayerNorm check bug (#6196) * fix(Layernorm): fix check bug * fix judge whether cpu or not Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * add glu op (#6065) * add glu op * del glu_op export，align with torch * mod glu_op * mov op logic to C++ * Solve problems * solve conflict * delete gradient functor * add ndim check * add GLU test * delete blank line * format Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> Co-authored-by: Zhenhua <huangzhenhua@zhejianglab.com> * Primitive based copy task node (#6195) Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * KernelState (#6198) Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * container_util: fix VectorAt, remove useless MutMapAt (#6172) * fcontainer_util: fix VectorAt, remove useless MutMapAt * fcontainer_util: format * MapAt: add default value version * format Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Refine StreamContext (#6191) Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Cpu symetric s to s (#6153) * mv_boxing_folder_to_core * minor fix * cpu_symetric_s_to_s * add test case * auto format by CI * minor fix * refine * Update eager_nccl_kernels.cpp * minor fix * fix bug * minor fix * Update oneflow/user/kernels/eager_nccl_kernels.cpp Co-authored-by: daquexian <daquexian566@gmail.com> * Update eager_nccl_kernels.cpp * Update eager_nccl_kernels.cpp * minor fix * Update eager_nccl_kernels.cpp Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org> Co-authored-by: daquexian <daquexian566@gmail.com> * fix bug (#6197) Co-authored-by: Yinggang Wang <wyg19970408@gmail.com> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * fix consistent tensor zeros (#6202) Signed-off-by: daquexian <daquexian566@gmail.com> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * [Feat.] nn.Graph support grad acc with input/output tensor (#6155) * nn.Graph support grad acc with input/output tensor * dirty pass grad acc * revert tensor.backward hack * fix indent * default S0 -> B * Pack op/kernel support scalar input * nn.Graph output pack support loss scalar * add test script * pass test * Lazy build output eager tensors after job complete * non scalar output test Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Dev eliminate gcc warnings (#6199) * fix gcc warning * refine * fix comment Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * StreamContextAdapter (#6205) * StreamContextAdapter * refine Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Autotest generate input tensor (#6206) * Add tensor yaml, support export tensor functional api. * refine * Remove packed functor signature * remove unused file * Refine * refine * add activation op import * reinit oneflow init.py * add oneflow abs and exp * add oneflow abs and exp * add acos * add arccosh * add more op * add more ops * add more op * add more ops * add log1p * add more smaples * add more ops * add more ops * add more ops * add more ops * Complete tensor functional apis. * Fix pybind call * add more ops * add ops done * Add target of_functional_tensor_obj * Disable throw visibility warnings * fix target link * fix * fix incorrect use of flow.Tensor. * Fix error merge * fix * fix add unittest * refine * refine * fix * fix * add tensor doc * auto format by CI * refine * Fix * Add doc for python function * refine * add tensor method docstring * fix some bug * fix docs bug * Fix * auto format by CI * Tensor->tensor * Tensor->tensor * refine Tensor->tensor * fix * fix * fix * fix conflict * fix bug * fix ci bug * fix * delete diag op * fix conflict * Fix segment * fix * merge * autotest framework generate input tensor * autotest framework generate input tensor * fix bug * fix impl bug * refine * refine * refine * fix * fix * fix comments * delete useless * fix ci error * fix ci error Co-authored-by: hjchen2 <chenhoujiangcug@gmail.com> Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Cleanup KernelUtil (#6212) Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> * Rename flow to oneflow in user hint (#6190) * style(*): rename flow to oneflow in user hint * fix(*): fix doctest * auto format by CI * remove ddp speed test Signed-off-by: daquexian <daquexian566@gmail.com> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org> Co-authored-by: daquexian <daquexian566@gmail.com> * merg and refactor * refact code * add io identity for activation checkpointing Co-authored-by: Juncheng <liujuncheng1022@gmail.com> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> Co-authored-by: binbinHan <han_binbin@163.com> Co-authored-by: cheng cheng <472491134@qq.com> Co-authored-by: Yinggang Wang <wyg19970408@gmail.com> Co-authored-by: QiangX-man <87475073+QiangX-man@users.noreply.github.com> Co-authored-by: Zhenhua <huangzhenhua@zhejianglab.com> Co-authored-by: Twice <i@twice.moe> Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org> Co-authored-by: daquexian <daquexian566@gmail.com> Co-authored-by: ZZK <42901638+MARD1NO@users.noreply.github.com> Co-authored-by: Luyang <flowingsun007@163.com> Co-authored-by: Xiaoyu Zhang <35585791+BBuf@users.noreply.github.com> Co-authored-by: hjchen2 <chenhoujiangcug@gmail.com> * rm useless code * refien test * add skip * Fix bug of Multi-Client src tick output order * refactor * test pass * waning to info * import os * fix test * auto format by CI * refactor fix pipeline stage id pass algo * add refine test * insert identity when do pipeline * refine test * fix copy buffer * refien pipeline demo * format * Add input/output ctrl edge to DstSubTick for order io and callback_notify * add test scripts * remove note * add comment for using pipeling * add comment * rm useless to * avoid cpu run cuda test Co-authored-by: chengtbf <472491134@qq.com> Co-authored-by: peitingkuan <peitingkuan@163.com> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> Co-authored-by: Juncheng <liujuncheng1022@gmail.com> Co-authored-by: binbinHan <han_binbin@163.com> Co-authored-by: Yinggang Wang <wyg19970408@gmail.com> Co-authored-by: QiangX-man <87475073+QiangX-man@users.noreply.github.com> Co-authored-by: Zhenhua <huangzhenhua@zhejianglab.com> Co-authored-by: Twice <i@twice.moe> Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org> Co-authored-by: daquexian <daquexian566@gmail.com> Co-authored-by: ZZK <42901638+MARD1NO@users.noreply.github.com> Co-authored-by: Luyang <flowingsun007@163.com> Co-authored-by: Xiaoyu Zhang <35585791+BBuf@users.noreply.github.com> Co-authored-by: hjchen2 <chenhoujiangcug@gmail.com>

Flowingsun007 added 2 commits September 7, 2021 23:00

fix gcc warning

84b8073

refine

4e8fcdc

Flowingsun007 added bug enhancement labels Sep 8, 2021

liujuncheng reviewed Sep 8, 2021

View reviewed changes

Flowingsun007 added 2 commits September 8, 2021 09:46

fix comment

8d17d0e

Merge branch 'master' into dev_eliminate_gcc_warnings

55b274c

guo-ran approved these changes Sep 8, 2021

View reviewed changes

Merge branch 'master' into dev_eliminate_gcc_warnings

86e995d

Flowingsun007 added the automerge label Sep 8, 2021

Flowingsun007 requested a review from oneflow-ci-bot September 8, 2021 08:58

Flowingsun007 added system and removed bug labels Sep 8, 2021

oneflow-ci-bot removed their request for review September 8, 2021 09:51

Merge branch 'master' into dev_eliminate_gcc_warnings

ac3ee79

oneflow-ci-bot self-requested a review September 8, 2021 09:52

oneflow-ci-bot merged commit 158449d into master Sep 8, 2021

oneflow-ci-bot deleted the dev_eliminate_gcc_warnings branch September 8, 2021 11:52

jackalcooper reviewed Sep 8, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev eliminate gcc warnings #6199

Dev eliminate gcc warnings #6199

Flowingsun007 commented Sep 8, 2021 •

edited

Loading

liujuncheng Sep 8, 2021

Flowingsun007 Sep 8, 2021

github-actions bot commented Sep 8, 2021

jackalcooper Sep 8, 2021

		#ifdef WITH_CUDA_GRAPHS
		const bool updated = ctx_->UpdateTensorWithCorrBlob(BnInOp2Blob);

Dev eliminate gcc warnings #6199

Dev eliminate gcc warnings #6199

Conversation

Flowingsun007 commented Sep 8, 2021 • edited Loading

liujuncheng Sep 8, 2021

Choose a reason for hiding this comment

Flowingsun007 Sep 8, 2021

Choose a reason for hiding this comment

github-actions bot commented Sep 8, 2021

jackalcooper Sep 8, 2021

Choose a reason for hiding this comment

Flowingsun007 commented Sep 8, 2021 •

edited

Loading