Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make flow._C.local_all_reduce sync lanuched #6175

Merged
merged 8 commits into from
Sep 9, 2021
Merged

Conversation

daquexian
Copy link
Contributor

暂时把 flow._C.local_all_reduce 设置成 sync launched,这样子不会出现两卡结果不一致的问题,等待 allocator per stream 功能实现之后恢复

Signed-off-by: daquexian <daquexian566@gmail.com>
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot September 6, 2021 13:52
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot September 6, 2021 14:18
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot September 6, 2021 15:56
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2021

CI failed, removing label automerge

@github-actions github-actions bot removed the automerge label Sep 6, 2021
@oneflow-ci-bot oneflow-ci-bot removed their request for review September 6, 2021 17:17
@daquexian daquexian removed the request for review from oneflow-ci-bot September 8, 2021 14:13
@oneflow-ci-bot oneflow-ci-bot removed their request for review September 8, 2021 14:18
@oneflow-ci-bot oneflow-ci-bot self-requested a review September 8, 2021 16:36
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

CI failed, removing label automerge

@github-actions github-actions bot removed the automerge label Sep 8, 2021
@oneflow-ci-bot oneflow-ci-bot removed their request for review September 8, 2021 17:52
@oneflow-ci-bot oneflow-ci-bot self-requested a review September 9, 2021 01:06
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

Speed stats:
GPU Name: GeForce GTX 1080 

OneFlow resnet50 time: 127.8ms (= 6388.8ms / 50, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 142.1ms (= 7104.8ms / 50, input_shape=[16, 3, 224, 224])
Relative speed: 1.11 (= 142.1ms / 127.8ms)

OneFlow resnet50 time: 74.3ms (= 3712.8ms / 50, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 81.1ms (= 4053.5ms / 50, input_shape=[8, 3, 224, 224])
Relative speed: 1.09 (= 81.1ms / 74.3ms)

OneFlow resnet50 time: 47.9ms (= 2395.9ms / 50, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 60.0ms (= 3001.3ms / 50, input_shape=[4, 3, 224, 224])
Relative speed: 1.25 (= 60.0ms / 47.9ms)

OneFlow resnet50 time: 43.5ms (= 2176.8ms / 50, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 47.7ms (= 2383.5ms / 50, input_shape=[2, 3, 224, 224])
Relative speed: 1.09 (= 47.7ms / 43.5ms)

OneFlow resnet50 time: 42.9ms (= 2142.5ms / 50, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 40.6ms (= 2027.8ms / 50, input_shape=[1, 3, 224, 224])
Relative speed: 0.95 (= 40.6ms / 42.9ms)

@oneflow-ci-bot oneflow-ci-bot merged commit 7c3b42f into master Sep 9, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the sync_allreduce branch September 9, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants