Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong inplace acc grad #6146

Merged
merged 10 commits into from
Sep 3, 2021
Merged

Fix wrong inplace acc grad #6146

merged 10 commits into from
Sep 3, 2021

Conversation

hjchen2
Copy link
Contributor

@hjchen2 hjchen2 commented Sep 2, 2021

No description provided.

@oneflow-ci-bot oneflow-ci-bot removed their request for review September 3, 2021 03:41
@oneflow-ci-bot oneflow-ci-bot self-requested a review September 3, 2021 05:19
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot September 3, 2021 06:31
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot September 3, 2021 07:42
@oneflow-ci-bot oneflow-ci-bot self-requested a review September 3, 2021 09:00
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot September 3, 2021 11:29
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

Speed stats:
GPU Name: GeForce GTX 1080 

OneFlow resnet50 time: 128.6ms (= 6431.9ms / 50, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 141.3ms (= 7064.0ms / 50, input_shape=[16, 3, 224, 224])
Relative speed: 1.10 (= 141.3ms / 128.6ms)

OneFlow resnet50 time: 74.8ms (= 3741.3ms / 50, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 85.5ms (= 4272.6ms / 50, input_shape=[8, 3, 224, 224])
Relative speed: 1.14 (= 85.5ms / 74.8ms)

OneFlow resnet50 time: 48.2ms (= 2408.6ms / 50, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 59.1ms (= 2955.9ms / 50, input_shape=[4, 3, 224, 224])
Relative speed: 1.23 (= 59.1ms / 48.2ms)

OneFlow resnet50 time: 42.9ms (= 2144.6ms / 50, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 46.0ms (= 2299.0ms / 50, input_shape=[2, 3, 224, 224])
Relative speed: 1.07 (= 46.0ms / 42.9ms)

OneFlow resnet50 time: 42.7ms (= 2134.7ms / 50, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 40.0ms (= 1999.8ms / 50, input_shape=[1, 3, 224, 224])
Relative speed: 0.94 (= 40.0ms / 42.7ms)

OneFlow resnet50 time: 140.3ms (= 7013.7ms / 50, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 159.5ms (= 7977.3ms / 50, input_shape=[16, 3, 224, 224], ddp, world size=2)
Relative speed: 1.14 (= 159.5ms / 140.3ms)

OneFlow resnet50 time: 90.8ms (= 4538.2ms / 50, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 100.5ms (= 5026.5ms / 50, input_shape=[8, 3, 224, 224], ddp, world size=2)
Relative speed: 1.11 (= 100.5ms / 90.8ms)

OneFlow resnet50 time: 69.7ms (= 3483.1ms / 50, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 84.8ms (= 4238.1ms / 50, input_shape=[4, 3, 224, 224], ddp, world size=2)
Relative speed: 1.22 (= 84.8ms / 69.7ms)

OneFlow resnet50 time: 64.3ms (= 3215.3ms / 50, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 78.4ms (= 3921.5ms / 50, input_shape=[2, 3, 224, 224], ddp, world size=2)
Relative speed: 1.22 (= 78.4ms / 64.3ms)

OneFlow resnet50 time: 62.2ms (= 3111.4ms / 50, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 63.3ms (= 3165.0ms / 50, input_shape=[1, 3, 224, 224], ddp, world size=2)
Relative speed: 1.02 (= 63.3ms / 62.2ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review September 3, 2021 12:54
@oneflow-ci-bot oneflow-ci-bot merged commit 18baa09 into master Sep 3, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the dev_fix_acc_grad branch September 3, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants