Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewUniqueId thread safe #6141

Merged
merged 4 commits into from
Sep 2, 2021
Merged

Conversation

liujuncheng
Copy link
Collaborator

NewUniqueId/UniqueStr 目前被多处使用,应该实现为线程安全的

@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot September 2, 2021 08:09
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

CI failed, removing label automerge

@github-actions github-actions bot removed the automerge label Sep 2, 2021
@oneflow-ci-bot oneflow-ci-bot removed their request for review September 2, 2021 09:43
@oneflow-ci-bot oneflow-ci-bot self-requested a review September 2, 2021 11:18
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot September 2, 2021 12:31
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

Speed stats:
GPU Name: GeForce GTX 1080 

OneFlow resnet50 time: 127.8ms (= 6390.3ms / 50, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 143.1ms (= 7155.7ms / 50, input_shape=[16, 3, 224, 224])
Relative speed: 1.12 (= 143.1ms / 127.8ms)

OneFlow resnet50 time: 74.6ms (= 3730.4ms / 50, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 85.6ms (= 4281.6ms / 50, input_shape=[8, 3, 224, 224])
Relative speed: 1.15 (= 85.6ms / 74.6ms)

OneFlow resnet50 time: 49.0ms (= 2448.3ms / 50, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 59.8ms (= 2991.5ms / 50, input_shape=[4, 3, 224, 224])
Relative speed: 1.22 (= 59.8ms / 49.0ms)

OneFlow resnet50 time: 41.8ms (= 2090.4ms / 50, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 45.3ms (= 2264.1ms / 50, input_shape=[2, 3, 224, 224])
Relative speed: 1.08 (= 45.3ms / 41.8ms)

OneFlow resnet50 time: 35.1ms (= 1752.7ms / 50, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 39.5ms (= 1975.3ms / 50, input_shape=[1, 3, 224, 224])
Relative speed: 1.13 (= 39.5ms / 35.1ms)

OneFlow resnet50 time: 147.1ms (= 7355.6ms / 50, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 164.0ms (= 8199.6ms / 50, input_shape=[16, 3, 224, 224], ddp, world size=2)
Relative speed: 1.11 (= 164.0ms / 147.1ms)

OneFlow resnet50 time: 94.7ms (= 4734.7ms / 50, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 102.6ms (= 5131.6ms / 50, input_shape=[8, 3, 224, 224], ddp, world size=2)
Relative speed: 1.08 (= 102.6ms / 94.7ms)

OneFlow resnet50 time: 66.5ms (= 3324.4ms / 50, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 77.4ms (= 3868.3ms / 50, input_shape=[4, 3, 224, 224], ddp, world size=2)
Relative speed: 1.16 (= 77.4ms / 66.5ms)

OneFlow resnet50 time: 63.4ms (= 3170.3ms / 50, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 74.7ms (= 3734.7ms / 50, input_shape=[2, 3, 224, 224], ddp, world size=2)
Relative speed: 1.18 (= 74.7ms / 63.4ms)

OneFlow resnet50 time: 65.3ms (= 3262.7ms / 50, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 59.6ms (= 2978.4ms / 50, input_shape=[1, 3, 224, 224], ddp, world size=2)
Relative speed: 0.91 (= 59.6ms / 65.3ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review September 2, 2021 13:43
@oneflow-ci-bot oneflow-ci-bot merged commit d865dc9 into master Sep 2, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the dev_new_unique_id_thread_safe branch September 2, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants