-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to local #6098
Refactor to local #6098
Conversation
…refactor_to_local Conflicts: oneflow/core/autograd/gradient_funcs/consistent_cast.cpp
@@ -57,9 +55,8 @@ class ConsistentToConsistentGradFunction : public OpExprGradFunction<ConsistentT | |||
const auto& grad_nd_sbp = | |||
grad_nd_sbp_.has_value() ? JUST(grad_nd_sbp_.value()) : JUST(out_grad->nd_sbp()); | |||
const auto& grad_sbp_list = JUST(GetSbpList(grad_nd_sbp)); | |||
const auto& grad_grad_sbp_list = JUST(GetSbpList(ctx->nd_sbp)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
删掉这里的理由是什么呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
删掉这里的理由是什么呢?
这里本来就是后向过程,不需要在此处配置后向的后向,可参考:https://github.com/Oneflow-Inc/oneflow/blob/master/oneflow/user/ops/hierarchical_parallel_cast_op.cpp#L92
CI failed, removing label automerge |
CI failed, removing label automerge |
Speed stats:
|
oneflow/core/autograd/gradient_funcs/hierarchical_parallel_cast.cpp
,由于ConsistentToConsistentOpExpr有注册专门的后向function,此文件不在需要,故删除