Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix var bug #5973

Merged
merged 20 commits into from
Aug 21, 2021
Merged

Try to fix var bug #5973

merged 20 commits into from
Aug 21, 2021

Conversation

BBuf
Copy link
Contributor

@BBuf BBuf commented Aug 20, 2021

  • 和Pytorch对齐var,默认是贝塞尔无偏估计。
  • 添加flow.var自动测试样例。
  • 添加Tensor.var自动测试样例。
  • 修复自动测试脚本的一个BUG。

@BBuf BBuf changed the title Tyr to fix var bug Try to fix var bug Aug 20, 2021
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 20, 2021 08:23
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@oneflow-ci-bot oneflow-ci-bot self-requested a review August 20, 2021 09:35
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 20, 2021 10:35
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 20, 2021 11:50
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 20, 2021 12:36
@BBuf BBuf added the automerge label Aug 20, 2021
@BBuf BBuf requested a review from oneflow-ci-bot August 20, 2021 13:42
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 20, 2021 13:48
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 139.1ms (= 6954.1ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 127.8ms (= 6388.0ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.09 (= 139.1ms / 127.8ms)

PyTorch resnet50 time: 83.5ms (= 4174.6ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.4ms (= 3718.4ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.12 (= 83.5ms / 74.4ms)

PyTorch resnet50 time: 57.6ms (= 2878.7ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 47.1ms (= 2352.9ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.22 (= 57.6ms / 47.1ms)

PyTorch resnet50 time: 50.1ms (= 2503.0ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 42.2ms (= 2110.6ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.19 (= 50.1ms / 42.2ms)

PyTorch resnet50 time: 43.7ms (= 2184.7ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 35.5ms (= 1774.1ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.23 (= 43.7ms / 35.5ms)

@BBuf BBuf added the api label Aug 21, 2021
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 21, 2021 03:13
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 21, 2021 04:14
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 140.2ms (= 7010.4ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 128.3ms (= 6415.5ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.09 (= 140.2ms / 128.3ms)

PyTorch resnet50 time: 85.2ms (= 4261.2ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.6ms (= 3727.8ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.14 (= 85.2ms / 74.6ms)

PyTorch resnet50 time: 58.4ms (= 2918.4ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 47.3ms (= 2367.2ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.23 (= 58.4ms / 47.3ms)

PyTorch resnet50 time: 49.8ms (= 2487.8ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 37.8ms (= 1892.4ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.31 (= 49.8ms / 37.8ms)

PyTorch resnet50 time: 41.9ms (= 2093.9ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 37.6ms (= 1880.8ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.11 (= 41.9ms / 37.6ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 21, 2021 06:20
@oneflow-ci-bot oneflow-ci-bot merged commit fc60e22 into master Aug 21, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the tyr_to_fix_var_bug branch August 21, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants