-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export fused_scale_tril op #5933
Conversation
} else { | ||
scale = ctx->integer_scale_value; | ||
} | ||
(*in_grads)[0] = JUST(functional::FusedScaleTril(out_grads[0], ctx->diagonal, 0, scale)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个地方的第三个参时(0)我不大懂,看老 lazy 的注册梯度,这个 filled_value 其实就是正向 filled_value
属性(float和int都包括)。但是这里直接写死为 0 了。是可以的吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
前向,保留下三角矩阵,反向传播时,梯度也保留下三角矩阵。看 tril_op.cpp 里面也是这么写的,反向没传 fill_value (默认是 0)
CI failed, removing label automerge |
…neflow into f_fused_scale_tril
Speed stats:
|
No description provided.