Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add clang-tidy check to test.yaml #5920

Merged
merged 11 commits into from
Aug 18, 2021

Conversation

PragmaTwice
Copy link
Contributor

@PragmaTwice PragmaTwice commented Aug 17, 2021

  • 使用 ccache 将依赖构建时间从 20min 缩减到 4min
  • 使用 clang-tidy-diff 仅检查有改动的文件
  • 修复 opencv 的 ccache 设置

@daquexian
Copy link
Contributor

daquexian commented Aug 17, 2021

https://github.com/Oneflow-Inc/oneflow/pull/5920/checks?check_run_id=3347898225 从这里来看时间可以满足要求。不过看到两个有点坑的问题:

  1. 从源码来看 clang-tidy-diff.py 的返回值总是 0,不像 run-clang-tidy.py
  2. https://github.com/Oneflow-Inc/oneflow/pull/5920/checks?check_run_id=3347898225 这里报的错和本次 pr 无关,甚至报错的代码也是已在一个几个小时前的 pr 里被删掉的旧代码,不知道是不是因为这个 pr 是跨仓库的,所以 clone 的 master 代码不正确

@PragmaTwice PragmaTwice requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 17, 2021 11:58
@PragmaTwice PragmaTwice requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 17, 2021 12:01
@PragmaTwice PragmaTwice requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 17, 2021 12:10
@PragmaTwice PragmaTwice requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 17, 2021 12:35
@PragmaTwice PragmaTwice requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 17, 2021 13:16
@PragmaTwice PragmaTwice removed the request for review from oneflow-ci-bot August 17, 2021 13:44
@PragmaTwice PragmaTwice requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 17, 2021 13:44
@PragmaTwice PragmaTwice requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 18, 2021 05:57
@oneflow-ci-bot oneflow-ci-bot merged commit 3e7aed1 into Oneflow-Inc:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants