-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add clang-tidy check to test.yaml #5920
Merged
oneflow-ci-bot
merged 11 commits into
Oneflow-Inc:master
from
PragmaTwice:ci-test-add-tidy
Aug 18, 2021
Merged
CI: add clang-tidy check to test.yaml #5920
oneflow-ci-bot
merged 11 commits into
Oneflow-Inc:master
from
PragmaTwice:ci-test-add-tidy
Aug 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PragmaTwice
commented
Aug 17, 2021
•
edited
Loading
edited
- 使用 ccache 将依赖构建时间从 20min 缩减到 4min
- 使用 clang-tidy-diff 仅检查有改动的文件
- 修复 opencv 的 ccache 设置
daquexian
reviewed
Aug 17, 2021
https://github.com/Oneflow-Inc/oneflow/pull/5920/checks?check_run_id=3347898225 从这里来看时间可以满足要求。不过看到两个有点坑的问题:
|
daquexian
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.