Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set CMAKE_BUILD_TYPE to Release if undefined #5842

Merged
merged 5 commits into from
Aug 11, 2021

Conversation

daquexian
Copy link
Contributor

修复 #5656 带来的问题,在不设置 CMAKE_BUILD_TYPE 时将它设置成 Release

Signed-off-by: daquexian <daquexian566@gmail.com>
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 11, 2021 13:01
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 16:25
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 18:35
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 11, 2021 20:09
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 141.4ms (= 7068.7ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 128.2ms (= 6410.6ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.10 (= 141.4ms / 128.2ms)

PyTorch resnet50 time: 84.5ms (= 4226.0ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.5ms (= 3724.2ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.13 (= 84.5ms / 74.5ms)

PyTorch resnet50 time: 60.1ms (= 3006.7ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 47.4ms (= 2368.6ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.27 (= 60.1ms / 47.4ms)

PyTorch resnet50 time: 49.2ms (= 2461.3ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 40.1ms (= 2005.4ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.23 (= 49.2ms / 40.1ms)

PyTorch resnet50 time: 38.0ms (= 1900.9ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 39.1ms (= 1956.2ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 0.97 (= 38.0ms / 39.1ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 11, 2021 21:54
@oneflow-ci-bot oneflow-ci-bot merged commit 2bf7379 into master Aug 11, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the fix_empty_build_type branch August 11, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants