Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTH_update_op_test #5823

Merged
merged 21 commits into from
Aug 11, 2021
Merged

RTH_update_op_test #5823

merged 21 commits into from
Aug 11, 2021

Conversation

rentainhe
Copy link
Contributor

本次提交的单测内容如下:

  • flow.eq
  • flow.tensor.eq
  • flow.equal (感觉是没有和torch对齐)
  • flow.exp
  • flow.tensor.exp
  • flow.erf
  • flow.tensor.erf
  • flow.erfc
  • flow.tensor.erfc
  • flow.round
  • flow.tensor.round
  • flow.tensor.expand

Flatten相关的天宇已经完成了

  • flow.nn.Flatten
  • flow.flatten

To相关的不需要测试

return x.eq(y)

@autotest(auto_backward=False)
def test_flow_tensor_eq_with_same_random_data(test_case):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看了一下torch.equal,和我们的语意确实没有对齐,torch.equal是判断两个Tensor是不是完全一样,shape和value,你解决一下吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,OK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个我到时候单独作为一个PR提交吧

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好,刚试了下还比较麻烦,先记一下TODO吧,下个pr做

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的我这边会记着然后去做一下,这个PR可以先Merge

@rentainhe rentainhe requested a review from BBuf August 10, 2021 09:19
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 10, 2021 09:54
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 10, 2021 10:25
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 10, 2021 13:20
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 10, 2021 16:31
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 10, 2021 17:45
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 10, 2021 19:11
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 10, 2021 23:39
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 01:13
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 11, 2021 02:49
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 04:35
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 11, 2021 07:22
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 08:22
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 11, 2021 09:57
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 11:37
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 12:59
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 140.5ms (= 7025.3ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 127.6ms (= 6381.0ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.10 (= 140.5ms / 127.6ms)

PyTorch resnet50 time: 83.8ms (= 4191.5ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.2ms (= 3709.3ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.13 (= 83.8ms / 74.2ms)

PyTorch resnet50 time: 56.0ms (= 2801.6ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 49.7ms (= 2484.1ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.13 (= 56.0ms / 49.7ms)

PyTorch resnet50 time: 44.7ms (= 2234.2ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 40.7ms (= 2034.7ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.10 (= 44.7ms / 40.7ms)

PyTorch resnet50 time: 43.4ms (= 2167.8ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 46.3ms (= 2314.9ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 0.94 (= 43.4ms / 46.3ms)

@oneflow-ci-bot oneflow-ci-bot merged commit 1661b44 into master Aug 11, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the rth_op_test branch August 11, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants