-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_eager_boxing_and_op_interpreter_dispatch_error_info #5819
add_eager_boxing_and_op_interpreter_dispatch_error_info #5819
Conversation
<< "Eager boxing type \'" << ParallelDistributionToString(in_parallel_distribution) | ||
<< " -> " << ParallelDistributionToString(out_parallel_distribution) << "\'" | ||
<< "not support yet\n" | ||
<< "============ Supported eager boxing type============\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个可以提成一个公共的函数返回?这个 support boxing type 会增加的吧,不用改三处了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已提供公共函数
<< "Got tensors with inconsistent attributes!\n" | ||
<< "op_type_name: " << op_expr.op_type_name() << "\n" | ||
<< "first input tensor: local\n" | ||
<< "secind input tensor: consistent"; // unroll loop for efficiency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
secind -> second ? 检查一下注释的语法和拼写错误
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂手抖,已修改拼写错误
<< "Got tensors with inconsistent attributes!\n" | ||
<< "op_type_name: " << op_expr.op_type_name() << "\n" | ||
<< "first input tensor: consistent\n" | ||
<< "seciod input tensor: local"; // unroll loop for efficiency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
secind seciod 你这个真是啥拼写都有啊 😂 其实没必要重复写这么多。变成 op_expr , inputs -> ErrorString 的函数就行了,也不需要区分是 first、second,你遍历 inputs,把每个 tensor 是 local 还是 Consistent 都输出出来,说这些不一致,要么全是 local 的,要么全是 Consistent 的。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inputs size 小于等于3时,直接判断效率会跟高一点,当大于3时才遍历 inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其实不会影响效率,你把函数调用放在 CHECK 后面的输出流里,当 CHECK 失败的时候才会触发,而不是每次调用都会触发,那么不出错的时候就没有开销(0),出错的时候, 多少开销都不重要了吧
…' of https://github.com/Oneflow-Inc/oneflow into add_eager_boxing_and_op_interpreter_dispatch_error_info
…add_eager_boxing_and_op_interpreter_dispatch_error_info Conflicts: oneflow/core/framework/op_interpreter/boxing/eager_boxing_interpreter_mgr.cpp
Speed stats:
|
eager boxing与op_interpreter dispatch添加错误信息