Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naive b2p error #5806

Merged
merged 8 commits into from
Aug 9, 2021
Merged

Fix naive b2p error #5806

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3729a30
fix bug
clackhan Aug 9, 2021
e881006
refine
clackhan Aug 9, 2021
1a3b80a
Merge branch 'master' into fix_naive_b2p_error
oneflow-ci-bot Aug 9, 2021
3b273f3
Merge branch 'master' into fix_naive_b2p_error
oneflow-ci-bot Aug 9, 2021
6ed1869
Merge branch 'master' into fix_naive_b2p_error
oneflow-ci-bot Aug 9, 2021
e108459
Merge branch 'master' into fix_naive_b2p_error
oneflow-ci-bot Aug 9, 2021
434acd0
Merge branch 'master' into fix_naive_b2p_error
oneflow-ci-bot Aug 9, 2021
a35b9a0
Merge branch 'master' into fix_naive_b2p_error
oneflow-ci-bot Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions oneflow/core/framework/op_interpreter/boxing/naive_b2p_boxing_interpreter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,8 @@ Maybe<one::Tensor> NaiveB2PBoxingInterpreter::InterpretImpl(
Symbol<ParallelDesc> in_parallel_desc, Symbol<ParallelDesc> out_parallel_desc) const {
CHECK_EQ_OR_RETURN(in_parallel_desc, out_parallel_desc);
int64_t root = JUST(in_parallel_desc->MachineId4ParallelId(0));
if (root == GlobalProcessCtx::LocalRank()) {
std::string device_type = Device::Type4DeviceTag(in_parallel_desc->device_tag());
return JUST(one::functional::Copy(input, device_type, root));
if (root == GlobalProcessCtx::Rank()) {
return JUST(one::functional::Identity(input));
} else {
return JUST(one::functional::ZerosLike(input));
}
Expand Down