stateful local kernel supports consistent #5789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: daquexian <daquexian566@gmail.com>
Signed-off-by: daquexian <daquexian566@gmail.com>
daquexian
commented
Aug 7, 2021
oneflow/core/framework/op_interpreter/eager_consistent_op_interpreter.cpp
Outdated
Show resolved
Hide resolved
lixinqi
reviewed
Aug 7, 2021
Signed-off-by: daquexian <daquexian566@gmail.com>
…t_consistent Signed-off-by: daquexian <daquexian566@gmail.com>
daquexian
force-pushed
the
local_kernel_support_consistent
branch
2 times, most recently
from
0961cde to
8e1cd8a
Compare
daquexian
commented
Aug 10, 2021
| @@ -17,16 +17,15 @@ | |||
| import os | |||
| import unittest | |||
|
|
|||
| import oneflow.compatible.single_client.unittest | |||
There was a problem hiding this comment.
把 python/oneflow/compatible/single_client/test/ops/test_stateful_local_kernel.py 挪了过来，它应该是 multi client 的测试。并且增加了可以覆盖新实现的接口的测试
|
|
||
| namespace oneflow { | ||
| namespace one { | ||
|
|
||
| template<class T> | ||
| class InputAndOutputListScope { |
Signed-off-by: daquexian <daquexian566@gmail.com>
daquexian
force-pushed
the
local_kernel_support_consistent
branch
from
8e1cd8a to
eaad668
Compare
lixinqi
approved these changes
Aug 10, 2021
oneflow/core/job/parallel_desc.cpp
Outdated
| @@ -183,6 +198,11 @@ Maybe<Symbol<Device>> GetDevice4CurrentProcessCtx(Symbol<ParallelDesc> parallel_ | |||
| return device_iter->second; | |||
| } | |||
|
|
|||
| std::shared_ptr<ParallelContext> GetParallelContext4CurrentProcessCtx( | |||
| Symbol<ParallelDesc> parallel_desc) { | |||
| return DECORATE(&RawGetParallelContext4CurrentProcessCtx, ThreadLocalCopiable)(parallel_desc); | |||
There was a problem hiding this comment.
ThreadLocal。
下意识地应该选择ThreadLocal，它会检查每个参数都是scalar，杜绝潜在的问题。
Signed-off-by: daquexian <daquexian566@gmail.com>
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eager consistent op interpreter 调用 stateful local opkernel 时传 consistent tensor meta，作为 sbp, logical shape 等的提供者。修复 logical slice 等 op 在 consistent tensor 上挂掉的问题