Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export datasets interface #5691

Merged
merged 14 commits into from
Aug 3, 2021
Merged

export datasets interface #5691

merged 14 commits into from
Aug 3, 2021

Conversation

Flowingsun007
Copy link
Contributor

No description provided.

@Flowingsun007 Flowingsun007 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 2, 2021 08:14
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 2, 2021 08:17
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 2, 2021 10:21
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 2, 2021 10:43
Comment on lines 376 to 377
from oneflow.utils import data
from oneflow.utils import vision
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没看出这两个为什么要放到顶层,这个PR里面也没有用到他们的地方

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

CI failed, removing label automerge

@github-actions github-actions bot removed the automerge label Aug 2, 2021
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 2, 2021 13:12
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 148.1ms (= 7402.8ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 126.8ms (= 6340.8ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.17 (= 148.1ms / 126.8ms)

PyTorch resnet50 time: 84.2ms (= 4209.5ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.2ms (= 3709.4ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.13 (= 84.2ms / 74.2ms)

PyTorch resnet50 time: 58.3ms (= 2916.3ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 47.5ms (= 2377.3ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.23 (= 58.3ms / 47.5ms)

PyTorch resnet50 time: 45.7ms (= 2284.9ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 41.2ms (= 2062.5ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.11 (= 45.7ms / 41.2ms)

PyTorch resnet50 time: 43.1ms (= 2155.3ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 42.5ms (= 2125.2ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.01 (= 43.1ms / 42.5ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 2, 2021 16:34
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 3, 2021 01:32
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 3, 2021 01:32
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 3, 2021 02:23
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 3, 2021 05:10
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

CI failed, removing label automerge

@github-actions github-actions bot removed the automerge label Aug 3, 2021
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 3, 2021 06:06
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 137.4ms (= 6867.6ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 124.1ms (= 6206.6ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.11 (= 137.4ms / 124.1ms)

PyTorch resnet50 time: 81.7ms (= 4086.4ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 72.5ms (= 3623.6ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.13 (= 81.7ms / 72.5ms)

PyTorch resnet50 time: 56.5ms (= 2824.2ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 46.2ms (= 2309.4ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.22 (= 56.5ms / 46.2ms)

PyTorch resnet50 time: 47.3ms (= 2364.9ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 37.3ms (= 1864.8ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.27 (= 47.3ms / 37.3ms)

PyTorch resnet50 time: 43.8ms (= 2188.1ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 37.6ms (= 1878.3ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.16 (= 43.8ms / 37.6ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 3, 2021 10:24
@oneflow-ci-bot oneflow-ci-bot merged commit b4d551d into master Aug 3, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the fix_datasets_export branch August 3, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants