Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix return type error on gcc 4.8.5 #5660

Merged
merged 10 commits into from
Jul 30, 2021
Merged

fix return type error on gcc 4.8.5 #5660

merged 10 commits into from
Jul 30, 2021

Conversation

daquexian
Copy link
Contributor

通过在 UNIMPLEMENTED() 后面加 return、把 UNIMPLEMENTED() 改成 UNIMPLEMENTED_THEN_RETURN() 消除编译错误,在 zhenhua 的环境下验证可行

Signed-off-by: daquexian <daquexian566@gmail.com>
@oneflow-ci-bot oneflow-ci-bot self-requested a review July 29, 2021 10:08
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 29, 2021 12:28
@oneflow-ci-bot oneflow-ci-bot self-requested a review July 29, 2021 17:09
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 29, 2021 19:38
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 29, 2021 21:26
@oneflow-ci-bot oneflow-ci-bot self-requested a review July 30, 2021 01:40
@daquexian daquexian requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 30, 2021 02:03
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 140.6ms (= 7030.0ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 126.3ms (= 6314.8ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.11 (= 140.6ms / 126.3ms)

PyTorch resnet50 time: 85.0ms (= 4249.3ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 73.8ms (= 3691.3ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.15 (= 85.0ms / 73.8ms)

PyTorch resnet50 time: 57.6ms (= 2879.1ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 47.2ms (= 2361.0ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.22 (= 57.6ms / 47.2ms)

PyTorch resnet50 time: 49.2ms (= 2460.8ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 42.0ms (= 2099.3ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.17 (= 49.2ms / 42.0ms)

PyTorch resnet50 time: 42.6ms (= 2131.6ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 42.0ms (= 2100.6ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.01 (= 42.6ms / 42.0ms)

@oneflow-ci-bot oneflow-ci-bot merged commit f6b849b into master Jul 30, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the fix_no_return branch July 30, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants