GlobalMultiClientEnv and refine EagerExecution #5523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clackhan
reviewed
Jul 16, 2021
Comment on lines
37
to
38
| Maybe<bool> GlobalMultiClientEnv(); | ||
|
|
There was a problem hiding this comment.
这个接口放在env_desc.h文件中是不是更合适一点。还可以基于这个接口简单重构一下api中IsMultiClient的实现
There was a problem hiding this comment.
改了，放在 env 里了。另外 api 里面的我没动，感觉重构也没太大意义，还省去了一个 include。
…eflow-Inc/oneflow into dev_cc_lazy_mode_enable_eager
strint
approved these changes
Jul 16, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global<GlobalJobBuildAndInferCtxMgr>的逻辑，首先会判断是否是 Multi-Client：- 如果是 Multi-Client，直接返回 LazyMgr
- 如果是 Single-Client，再根据 Single-Client 下的逻辑判断是否设置了标记 eager_execution_enabled，如果是，则 Eager 执行 global_function ，否则 Lazy 执行 global_function
这样我们新版的 torch 代码就跟 enable_eager_execution 完全无关了。
本 PR 不依赖对 enable_eager_execution 标记的移除；也不依赖 Compatible Single-Client 的迁移