Job pass maybe system #5503
Merged
Job pass maybe system #5503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixinqi
requested review from
liujuncheng,
daquexian,
chengtbf and
oneflow-ci-bot
lixinqi
commented
Jul 15, 2021
| @@ -532,8 +532,7 @@ void TaskGraph::ConnectCtrlEdges(const std::vector<CompTaskNode*>& src_task_node | |||
| CHECK_EQ(src_task_nodes.size(), dst_task_nodes.size()); | |||
| FOR_RANGE(int32_t, i, 0, src_task_nodes.size()) { | |||
| std::string regst_desc_name; | |||
| RegstDesc* ctrl_regst_desc = | |||
There was a problem hiding this comment.
解决一直有的编译警告unused variable。
|
|
||
| Maybe<void> AddMultiClientSourceAndSinkPass::Apply(const OpGraph& op_graph, | ||
| JobBuilder* job_builder) const { | ||
| TODO_THEN_RETURN(); |
There was a problem hiding this comment.
下一个pr把这里丰富了。目前这里写个todo也不会有什么事情发生，因为只有multi-client才会走到这里。
liufengwei0103
approved these changes
Jul 15, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
将job_pass中部分的glog CHECK换成了maybe CHECK