Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi client launcher test #5488

Merged
merged 18 commits into from
Jul 19, 2021
Merged

multi client launcher test #5488

merged 18 commits into from
Jul 19, 2021

Conversation

daquexian
Copy link
Contributor

multi client launcher 的测试。

新增 ci/test_multi_client 文件夹,增加 test_allreduce.py,给已有的 module 测试都加上 skip_unless_1n1d

@daquexian daquexian requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 14, 2021 08:08
@oneflow-ci-bot oneflow-ci-bot removed their request for review July 14, 2021 09:26
Signed-off-by: daquexian <daquexian566@gmail.com>
@daquexian daquexian requested a review from oneflow-ci-bot July 14, 2021 09:50
Signed-off-by: daquexian <daquexian566@gmail.com>
@daquexian daquexian requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 14, 2021 13:29
@oneflow-ci-bot oneflow-ci-bot removed their request for review July 14, 2021 21:35
Signed-off-by: daquexian <daquexian566@gmail.com>
@daquexian daquexian requested a review from oneflow-ci-bot July 15, 2021 01:09
@jackalcooper
Copy link
Collaborator

note:
CI显示launcher的方式似乎overhead有点大,之前的module测试大约是7分钟,launcher的方式快40分钟还没跑完

@oneflow-ci-bot oneflow-ci-bot removed their request for review July 15, 2021 03:24
Signed-off-by: daquexian <daquexian566@gmail.com>
@daquexian daquexian force-pushed the multi_client_test branch from d630f1f to 9b19442 Compare July 18, 2021 12:05
…or loop to speed up the test

Signed-off-by: daquexian <daquexian566@gmail.com>
@daquexian daquexian requested a review from oneflow-ci-bot July 18, 2021 13:15
@daquexian daquexian requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 19, 2021 01:07
@oneflow-ci-bot oneflow-ci-bot removed their request for review July 19, 2021 01:55
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 19, 2021 01:55
@oneflow-ci-bot oneflow-ci-bot merged commit b092835 into master Jul 19, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the multi_client_test branch July 19, 2021 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants