-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-Client LogicalRun degenerate to PhysicalRun #5479
Conversation
看起来没问题,如果测试可以过应该就是ok的,test_graph.py里面会触发这里 |
test_graph.py 目前单测会测到吗? @strint @jackalcooper 我在 CI 的 workflow 里没找到对应的,只有 test/modules 和 test/tensor 的目录下才会触发吧? |
test_graph.py的make_scope测试会触发MultiClient + LogicalRun的执行。不过还是单进程的。 |
是的。目前还没有 Multi-Client 下的多进程单测。 我好奇的是,我们在 |
|
在 Multi-Client 下,虚拟机 VM 的 指令: LogicalRun 会直接退化成 PhysicalRun,因为每个 rank 都 只会收到和处理本 rank 的指令,不会再有 rank 之间的 指令级别的同步(对应之前 Single-Client 下的 ClusterInstruction)
补充: