Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instruction builder return maybe #5442

Merged
merged 5 commits into from
Jul 9, 2021
Merged

instruction builder return maybe #5442

merged 5 commits into from
Jul 9, 2021

Conversation

liufengwei0103
Copy link
Contributor

instruction builder return maybe

@liufengwei0103 liufengwei0103 force-pushed the InstructionBuilder_return_maybe branch 4 times, most recently from 0678190 to f517e84 Compare July 9, 2021 08:46
@liufengwei0103 liufengwei0103 requested a review from lixinqi July 9, 2021 08:51
@liufengwei0103 liufengwei0103 force-pushed the InstructionBuilder_return_maybe branch from f517e84 to a72f850 Compare July 9, 2021 09:04
@liufengwei0103 liufengwei0103 force-pushed the InstructionBuilder_return_maybe branch from a72f850 to 6950b12 Compare July 9, 2021 09:14
lixinqi
lixinqi approved these changes Jul 9, 2021
View reviewed changes
oneflow/api/python/framework/instructions_builder.cpp
Comment on lines +257 to +260
return LogicalRun([&](InstructionsBuilder* instruction_builder) -> Maybe<void> {
Build(instruction_builder);
return Maybe<void>::Ok();
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里处理得很细腻。

@lixinqi
Copy link
Contributor

lixinqi commented Jul 9, 2021

确认了所有的LogicalRun，PhysicalRun都改过来了吗？

@liufengwei0103
Copy link
Contributor Author

确认了所有的LogicalRun，PhysicalRun都改过来了吗？

都改了，调用的地方不是很多。

@oneflow-ci-bot oneflow-ci-bot removed their request for review July 9, 2021 10:51
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 9, 2021 10:52
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 9, 2021 12:31
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 9, 2021 13:37
@oneflow-ci-bot oneflow-ci-bot merged commit 0089263 into master Jul 9, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the InstructionBuilder_return_maybe branch July 9, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lixinqi lixinqi lixinqi approved these changes

Assignees
No one assigned
Labels
api automerge enhancement system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liufengwei0103 @lixinqi @oneflow-ci-bot