Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix segfault in clang plugin #5437

Merged
merged 13 commits into from
Jul 9, 2021
Merged

fix segfault in clang plugin #5437

merged 13 commits into from
Jul 9, 2021

Conversation

daquexian
Copy link
Contributor

  1. 只在 !returnType.isNull() && returnType->isClassType() 成立时调用 getAsString()，避免 segfault
  2. 不设置 ONEFLOW_MAYBE_CHECK_ONLY_FN 和 ONEFLOW_MAYBE_CHECK_SKIP_FN（没有必要了），改为只在编译 oneflow 本体时设置 plugin

daquexian added 7 commits July 9, 2021 09:37
@daquexian
format
6689710 
Signed-off-by: daquexian <daquexian566@gmail.com>
@daquexian
only call getAsString() when isClassType() is true
aadf81d 
Signed-off-by: daquexian <daquexian566@gmail.com>
@daquexian
only call getAsString() when not null and isClassType() is true
4f7fb44 
Signed-off-by: daquexian <daquexian566@gmail.com>
@daquexian
unset env vars, only set plugin when building oneflow itself
b4ba4da 
Signed-off-by: daquexian <daquexian566@gmail.com>
@daquexian
reformat to llvm style
19a13ea 
Signed-off-by: daquexian <daquexian566@gmail.com>
@daquexian
Merge remote-tracking branch 'origin/master' into clang_plugin_fix
80266a6
@daquexian
Debug -> Release
8df3396 
Signed-off-by: daquexian <daquexian566@gmail.com>
@oneflow-ci-bot oneflow-ci-bot self-requested a review July 9, 2021 04:50
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 9, 2021 06:38
daquexian and others added 2 commits July 9, 2021 15:00
@daquexian
add missing JUST in master
9f6149e 
Signed-off-by: daquexian <daquexian566@gmail.com>
@oneflow-ci-bot
Merge branch 'master' into clang_plugin_fix
73f0240
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 9, 2021 08:54
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 9, 2021 10:51
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 9, 2021 12:31
@oneflow-ci-bot oneflow-ci-bot merged commit 07a274b into master Jul 9, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the clang_plugin_fix branch July 9, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackalcooper jackalcooper jackalcooper approved these changes

Assignees
No one assigned
Labels
automerge bug ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daquexian @jackalcooper @oneflow-ci-bot