Optimize tensor getitem. #5433
Merged
Optimize tensor getitem. #5433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjchen2
requested review from
daquexian and
VertexC
and removed request for
daquexian
hjchen2
force-pushed
the
dev_optimize_tensor_getitem
branch
from
a4a90e7 to
bb9b330
Compare
hjchen2
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
lixinqi
reviewed
Jul 9, 2021
daquexian
reviewed
Jul 12, 2021
daquexian
reviewed
Jul 12, 2021
| }(); | ||
| std::shared_ptr<one::Tensor> result; | ||
| if (is_identity) { | ||
| result = x; |
There was a problem hiding this comment.
这样做的原因是什么呢，PyTorch 里 id(x) == id(x[:]) 是 False。如果是想模拟 PyTorch slicing 返回 view 的行为，是不是现在什么都不用做，等到支持了 view 之后这里的行为就自动和 pytorch 一致了
There was a problem hiding this comment.
这里是为了做性能优化，但确实可能会给用户造成混淆。我改一下
There was a problem hiding this comment.
identity的时候改成copy一把，性能应该会更高一些
hjchen2
force-pushed
the
dev_optimize_tensor_getitem
branch
from
48c8d36 to
4c4714a
Compare
…dev_optimize_tensor_getitem
daquexian
approved these changes
Jul 12, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.