Refactor build_wheel to support oneflowinc images #5427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daquexian
reviewed
Jul 8, 2021
| @@ -303,7 +305,7 @@ def is_img_existing(tag): | |||
| "--wheel_house_dir", type=str, required=False, default=default_wheel_house_dir, | |||
| ) | |||
| parser.add_argument( | |||
| "--python_version", type=str, required=False, default="3.6, 3.7, 3.8", | |||
| "--python_version", type=str, required=False, default="3.6", | |||
There was a problem hiding this comment.
感觉这个参数默认值有些尴尬，是不是让用户手动指定会合适些
daquexian
approved these changes
Jul 8, 2021
…refactor_build_wheel_to_support_oneflowinc_images
jackalcooper
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
deleted the
refactor_build_wheel_to_support_oneflowinc_images
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
提示用户去 dockerhub 下载 manylinux 的 docker 镜像
https://hub.docker.com/u/oneflowinc