Add flow xxx and tensor xxx autotest #5386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daquexian
reviewed
Jul 6, 2021
| device: str = "cuda", | ||
| training: bool = True, | ||
| backward: bool = True, | ||
| rtol=1e-4, | ||
| atol=1e-5, | ||
| n=20, | ||
| pytorch_module_class_name=None, | ||
| api_flag: int = 0, |
There was a problem hiding this comment.
还有一些 0 1 2 没有改成 TEST_MODULE 等常量
| def has_full_args_spec(args): | ||
| if args == set(): | ||
| return False | ||
| return True |
There was a problem hiding this comment.
啊不是的，是这样：
def has_full_args_spec(callable):
try:
spec = inspect.getfullargspec(callable)
return True
except Exception:
return False然后 164 行-169 行可以一起改成
torch_module_class = eval(f"torch.{pytorch_module_class_name}")
if has_full_arg_spec(torch_module_class):
spec = inspect.getfullargspec(torch_module_class)
else:
spec = xxxx| try: | ||
| torch_module_class = eval(f"torch.{pytorch_module_class_name}") | ||
| spec = inspect.getfullargspec(torch_module_class) | ||
| except Exception as e: |
| args = (set(spec.args) | set(spec.kwonlyargs)) - {"self"} | ||
| if has_full_args_spec(args) == False: |
There was a problem hiding this comment.
Suggested change
| if has_full_args_spec(args) == False: | |
| if not has_full_args_spec(args): |
| if has_default(name): | ||
| if rng.random() < 1 / 3: | ||
| continue | ||
| if api_flag == TEST_MODULE: |
There was a problem hiding this comment.
那这个 if 是不是也没有必要，不管测试什么都需要处理 default
| test_case, | ||
| module_class_name, | ||
| extra_annotations: Optional[Dict[str, Any]] = None, | ||
| extra_generators: Optional[Dict[str, Any]] = None, | ||
| extra_defaults: Optional[Dict[str, Any]] = None, | ||
| device: str = "cuda", | ||
| training: bool = True, | ||
| backward: bool = True, | ||
| rtol=1e-4, | ||
| atol=1e-5, | ||
| n=20, | ||
| pytorch_module_class_name=None, |
daquexian
reviewed
Jul 6, 2021
| return True | ||
| except Exception: | ||
| return False | ||
|
|
||
| torch_module_class = eval(f"torch.{pytorch_module_class_name}") |
There was a problem hiding this comment.
api_flag 是 TEST_TENSOR 的时候，这里是不是要改，先生成一个 torch tensor，再获取函数对象、拿到 spec
daquexian
reviewed
Jul 7, 2021
| @@ -183,9 +209,6 @@ def generate(name): | |||
| flow_attr_dict = {} | |||
| torch_attr_dict = {} | |||
| for name in args: | |||
| if has_default(name): | |||
| if rng.random() < 1 / 3: | |||
| continue | |||
| @@ -127,18 +132,20 @@ def generator(_): | |||
| return generator | |||
|
|
|||
|
|
|||
| def test_module_against_pytorch( | |||
| def test_against_pytorch( | |||
| test_case, | |||
| module_class_name, | |||
daquexian
reviewed
Jul 7, 2021
| assert args == set( | ||
| annotations.keys() | ||
| annotations.keys() | extra_defaults.keys() |
daquexian
approved these changes
Jul 7, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
….com/Oneflow-Inc/oneflow into add_flow_xxx_and_tensor_xxx_autotest
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
给flow.xxx 和 flow.Tensor.xxx 添加Pytorch自动测试测试。
test_module_against_pytorch 测试module
test_flow_against_pytorch 测试flow.xxx
test_tensor_against_pytorch 测试flow.Tensor.xxx