Fix upsample bilinear bug #5366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
…w-Inc/oneflow into fix_upsample_bilinear_bug
daquexian
reviewed
Jul 2, 2021
| return align_corners ? static_cast<T>(input_size - 1) / (output_size - 1) | ||
| : (scale > 0. ? 1.0 / scale : static_cast<T>(input_size) / output_size); | ||
| } else { | ||
| return 0; |
There was a problem hiding this comment.
我总感觉 pytorch output_size == 1 的时候 scale 直接 return 0 是个 bug，没有找到它为什么这么写的原理
There was a problem hiding this comment.
opencv是没有这个判断的，我也同意这个地方有问题，那这里还要不要特判。。
daquexian
reviewed
Jul 2, 2021
| @@ -98,14 +87,32 @@ template<typename T> | |||
| __device__ void GetBilinearParam(const bool align_corners, const int64_t h, const int64_t w, | |||
There was a problem hiding this comment.
.cu 和 .cpp 的 GetAreaPixelScale 和 GetBilinearParam 函数的实现是不是可以复用
daquexian
reviewed
Jul 2, 2021
| const int64_t in_h = GetNearestInputIndex(h, scale_h, in_height); | ||
| const int64_t in_w = GetNearestInputIndex(w, scale_w, in_width); | ||
| const int64_t in_h = GetNearestInputIndexFunc(h, scale_h, in_height); | ||
| const int64_t in_w = GetNearestInputIndexFunc(w, scale_w, in_width); |
daquexian
approved these changes
Jul 2, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
重构代码，和Pytorch完全对齐。
https://github.com/Quansight/pytorch/blob/74519b2a89039c5c77dfdfdd01d6fc23ca6d0367/aten/src/ATen/native/UpSampleBilinear2d.cpp#L60