Dev type as module #5349
Merged
Dev type as module #5349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eflow into dev_fix_slice_bug
BBuf
reviewed
Jun 29, 2021
| not flow.unittest.env.eager_execution_enabled(), | ||
| ".numpy() doesn't work in lazy mode", | ||
| ) | ||
| class TestPow(flow.unittest.TestCase): |
BBuf
reviewed
Jun 29, 2021
| ".numpy() doesn't work in lazy mode", | ||
| ) | ||
| class TestPow(flow.unittest.TestCase): | ||
| def test_pow_forward(test_case): |
BBuf
reviewed
Jun 29, 2021
|
|
||
| def _test_type_as(test_case, shape, device): | ||
| np_input = np.random.rand(*shape) | ||
| input = flow.tensor(np_input, dtype=flow.float, device=device) |
There was a problem hiding this comment.
这里感觉测试不全面，我理解可以写两个dtype的数组来遍历着测试
BBuf
approved these changes
Jun 29, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新增：type_as、long module及test case
api docs:
doc test:
