Add bmm module #5334
Merged
Add bmm module #5334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| super().__init__() | ||
|
|
||
| def forward(self, input, mat2): | ||
| return flow.F.batch_matmul(input, mat2) |
There was a problem hiding this comment.
对input和mat2的维度加一下check吧
… into add_bmm_module
Flowingsun007
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加bmm module。api文档如下：
doctest
为什么没有对齐pytorch的两个attr参数，考虑到如下原因：
deterministic : 和具体选取哪种实现方法有关系，oneflow只有一种计算方法。
out ：将一个输出tensor作为属性传进来，因为bmm返回的就是一个Tensor，所以丢弃这个参数。