Dev image decode eager #5333
Merged
Dev image decode eager #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldpe2G
reviewed
Jun 28, 2021
| diff_index = np.where(diff != 0) | ||
| diff_abs_values = diff[diff_index] | ||
|
|
||
| # only green channel has difference of 1 |
There was a problem hiding this comment.
为什么 green 会差1，和 用 Image有关系吗，用 opencv 呢，我看 image_decode_kernel 的实现也是用 opencv
There was a problem hiding this comment.
是的，是Image和opencv的差异，我测试了用cv2.imread, 和image_decode的结果是完全一样的，要改成cv2.imread吗
There was a problem hiding this comment.
那就换成cv.imread吧，因为这个检查看的有点懵，还是直接allclose易懂
Ldpe2G
approved these changes
Jun 29, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
不知要不要提供文档，之前dataset相关的module都没写，我也暂时没写