Fix create log directory thread-unsafe #5326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (IsDirectory(dirname)) { return; } | ||
| RecursivelyCreateDir(dirname); | ||
| std::string remaining_dir = dirname; | ||
| std::vector<std::string> sub_dirs; |
| void TestMultiThreadsDirOperation(FileSystem* file_system) { | ||
| std::string current_dir = GetCwd(); | ||
| StringReplace(¤t_dir, '\\', '/'); | ||
| std::string test_root_path = JoinPath(current_dir, "/tmp_multithread_test_dir"); |
There was a problem hiding this comment.
join path 第二个参数不需要加 / 吧
| @@ -86,9 +86,26 @@ void TestDirOperation(FileSystem* file_system) { | |||
| ASSERT_TRUE(!file_system->IsDirectory(test_root_path)); | |||
| } | |||
|
|
|||
| void CreateDirSimultaneously(FileSystem* file_system, const std::string& test_root_path) { | |||
There was a problem hiding this comment.
这个函数名字不太对？建议直接写到thread的闭包
jackalcooper
approved these changes
Jun 28, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.