Add cmake init cache to simplify user onboarding #5311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daquexian
reviewed
Jun 28, 2021
|
|
||
| run this to config for CUDA: | ||
| ``` | ||
| cmake .. -C ../cmake/caches/international/cuda.cmake |
There was a problem hiding this comment.
是不是可以在初次 cmake 时 ping google （并缓存结果）来判断需不需要用镜像 😂
There was a problem hiding this comment.
我也考虑过，之后可以做，不过不是这个PR要解决的问题，这个PR主要是引入 cmake init cache
daquexian
approved these changes
Jun 28, 2021
jackalcooper
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加 cmake 初始化 cache 文件，简化用户第一次编译 oneflow 需要配置的参数