replace train_conf, job_conf using cfg::xx #5263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengwei0103
force-pushed
the
replace_train_conf_job_conf_using_cfg_xx
branch
3 times, most recently
from
b5e10e0 to
1ceaccf
Compare
liufengwei0103
force-pushed
the
replace_train_conf_job_conf_using_cfg_xx
branch
from
1ceaccf to
ec8a16d
Compare
clackhan
reviewed
Jun 24, 2021
Comment on lines
-494
to
+496
| self.scale = [1] + list(scale) | ||
| self.scales = [1] + list(scale) |
There was a problem hiding this comment.
这一行不用改
我是感觉后面写for scale in self.scale: 很奇怪，就给改了。
There was a problem hiding this comment.
可以，仔细检查一下外部用到optimizer.py中接口的地方
liufengwei0103
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
clackhan
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.