Fix GRPC compilation failure on CMake 3.20 #5255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackalcooper
changed the title
poohRui
reviewed
Jun 21, 2021
cmake/third_party/grpc.cmake
Outdated
| @@ -10,28 +13,23 @@ set(GRPC_URL_HASH 0c6c3fc8682d4262dd0e5e6fabe1a7e2) | |||
| SET(GRPC_SOURCE_DIR ${CMAKE_CURRENT_BINARY_DIR}/grpc) | |||
|
|
|||
| if(WIN32) | |||
| set(GRPC_BUILD_LIBRARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/grpc/src/grpc/${CMAKE_BUILD_TYPE}) | |||
| set(GRPC_LIBRARY_NAMES grpc++_unsecure.lib | |||
| grpc_unsecure.lib gpr.lib upb.lib address_sorting.lib) | |||
There was a problem hiding this comment.
GRPC_BUILD_LIBRARY_DIR 这个目录用不到了，所以顺手删了
liujuncheng
approved these changes
Jun 21, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
…-Inc/oneflow into fix_cmake_320_grpc_cares
poohRui
approved these changes
Jun 21, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
…-Inc/oneflow into fix_cmake_320_grpc_cares
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复在 CMake 3.20.X 等高版本 CMake 下 GRPC 编译失败的问题