Fix support for Ninja and add Ninja build in Simple CI #5236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mv-default-third-party-dir-into-build-dir-1
jackalcooper
changed the base branch from
master
to
mv-default-third-party-dir-into-build-dir-1
jackalcooper
changed the title
Base automatically changed from
mv-default-third-party-dir-into-build-dir-1
to
master
June 18, 2021 07:47
daquexian
reviewed
Jun 18, 2021
| @@ -44,7 +44,7 @@ ExternalProject_Add(grpc | |||
| URL_HASH MD5=${GRPC_URL_HASH} | |||
| UPDATE_COMMAND "" | |||
| BUILD_IN_SOURCE 1 | |||
| BUILD_COMMAND make -j${PROC_NUM} grpc grpc_unsecure grpc++_unsecure | |||
| BUILD_COMMAND ${CMAKE_COMMAND} --build . -j ${PROC_NUM} -t grpc grpc_unsecure grpc++_unsecure | |||
There was a problem hiding this comment.
要不要顺便把 lz4.cmake、openssl.cmake、nccl.cmake 也改掉
There was a problem hiding this comment.
要不要顺便把 lz4.cmake、openssl.cmake、nccl.cmake 也改掉
好主意
There was a problem hiding this comment.
note
没有成功，因为那几个项目是make项目，cmake --build 如果调用的是 ninja，就会失败
…into support_ninja
daquexian
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.