job_config to cfg #5235
Merged
job_config to cfg #5235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clackhan
reviewed
Jun 21, 2021
Comment on lines
114
to
115
| JobConfigProto job_conf; | ||
| cfg_job_conf.ToProto(&job_conf); |
There was a problem hiding this comment.
这个文件没必要动，把这个toproto逻辑放在oneflow/api/python/job_build/job_build_and_infer.h中
There was a problem hiding this comment.
这个文件没必要动，把这个toproto逻辑放在
oneflow/api/python/job_build/job_build_and_infer.h中
已修改
liufengwei0103
force-pushed
the
job_config_to_cfg
branch
from
784524a to
a24cb0d
Compare
clackhan
reviewed
Jun 21, 2021
liufengwei0103
force-pushed
the
job_config_to_cfg
branch
3 times, most recently
from
1bd16eb to
237bbd0
Compare
liufengwei0103
force-pushed
the
job_config_to_cfg
branch
from
237bbd0 to
9341070
Compare
clackhan
approved these changes
Jun 22, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.