Refine CMake CUDA version handling #5192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackalcooper
changed the title
jackalcooper
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
liujuncheng
approved these changes
Jun 15, 2021
daquexian
reviewed
Jun 15, 2021
| else() | ||
| list(APPEND DEFAULT_CUDA_NVCC_GENCODES "arch=compute_70,code=compute_70") | ||
| endif() | ||
| list(APPEND DEFAULT_CUDA_NVCC_GENCODES "arch=compute_70,code=compute_70") | ||
| endif() | ||
| if(NOT DEFINED CUDA_NVCC_GENCODES) | ||
| set(CUDA_NVCC_GENCODES ${DEFAULT_CUDA_NVCC_GENCODES}) |
There was a problem hiding this comment.
165-167 行可以改成
set(CUDA_NVCC_GENCODES "${DEFAULT_CUDA_NVCC_GENCODES}" CACHE STRING "")…com/Oneflow-Inc/oneflow into cmake-log-cuda-version-and-root-dir
jackalcooper
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.