add ReflectionPad2d #5172
Merged
add ReflectionPad2d #5172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
BBuf
reviewed
Jun 15, 2021
|
|
||
| def forward(self, x): | ||
| H, W = x.shape[2], x.shape[3] | ||
| if self.padding[2] < H and self.padding[3] < H and self.padding[0] < W and self.padding[1] < W: |
There was a problem hiding this comment.
你这个对padding_size的限制有出处吗，看了一下和pytorch没对齐。具体可以看：https://pytorch.org/docs/stable/nn.functional.html#torch.nn.functional.pad
There was a problem hiding this comment.
参考的是旧的接口
oneflow/oneflow/python/ops/pad.py
Line 294 in 04046fc
There was a problem hiding this comment.
嗯，这个限制是没问题的，torch的op在c++层也做了同样的检查，不符合会报错的
| .Input("x") | ||
| .Output("y") | ||
| .Attr("padding", boundary) | ||
| .Attr("floating_value", float(1.)) |
There was a problem hiding this comment.
此op没有floating_value 、integral_value属性、不需要加
There was a problem hiding this comment.
目前这个op不传这两个属性会报错。因为C++端op里面有这三个属性。
oneflow/oneflow/user/ops/pad2d_ops.cpp
Line 51 in 0eec807
Flowingsun007
approved these changes
Jun 17, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ReflectionPad2d
doctest
docstring
unittest
