Add interface InferContext::InputDType #5153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -74,7 +74,7 @@ size_t InferTempStorageBytesSize(user_op::InferContext* ctx) { | |||
| const std::string& device_tag = ctx->device_tag(); | |||
| DeviceType device_type = CHECK_JUST(DeviceType4DeviceTag(device_tag)); | |||
| const Shape& input_shape = ctx->InputShape("input", 0); | |||
| DataType input_dtype = *ctx->Dtype4ArgNameAndIndex("input", 0); | |||
| DataType input_dtype = ctx->InputDType("input", 0); | |||
There was a problem hiding this comment.
这里是不是可以是const DataType&
liufengwei0103
approved these changes
Jun 11, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
InferContext::Dtype4ArgNameAndIndexintoInferContext::InputDTypeandInferContext::OutputDType(the latter is already implemented in #5125).