Infer consistent tensor meta #5118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clackhan
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
daquexian
reviewed
Jun 29, 2021
oneflow/core/framework/op_interpreter/eager_consistent_op_interpreter.cpp
Outdated
Show resolved
Hide resolved
oneflow/core/framework/op_interpreter/eager_consistent_op_interpreter.cpp
Outdated
Show resolved
Hide resolved
oneflow/core/framework/tensor_meta.h
Outdated
| template<> | ||
| struct hash<oneflow::one::ConsistentTensorMeta> final { | ||
| size_t operator()(const oneflow::one::ConsistentTensorMeta& other) const { | ||
| return other.CalcHashValue(); |
There was a problem hiding this comment.
CalcHashValue 和 hash_value 两种命名有什么区别
There was a problem hiding this comment.
CalcHashValue具有计算过程，hash_value是从对象上拿hash已经存在的值
daquexian
approved these changes
Jul 1, 2021
…infer_consistent_tensor_meta Conflicts: oneflow/core/framework/op_expr.h oneflow/core/framework/tensor.h oneflow/core/framework/tensor_impl.h
…infer_consistent_tensor_meta Conflicts: oneflow/core/framework/tensor_impl.cpp
clackhan
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
…flow-Inc/oneflow into infer_consistent_tensor_meta
clackhan
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
daquexian
reviewed
Jul 1, 2021
| const UserOpExpr& user_op_expr, const std::vector<BlobDesc>& blob_descs, | ||
| std::vector<ParallelDistributionInferHint>* hints) const; | ||
|
|
||
| static Maybe<ConsistentTensorMetaInferArgs> New() { |
There was a problem hiding this comment.
把 New 和 Init 合在一起吧，static Maybe<ConsistentTensorMetaInferArgs> New(const TensorTuple& input_tensors, Symbol<PlacementScope> placement_scope, const AttrMap& attrs);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用ConsistentTensorInferCache来加速推导eager conssitent tensor的元信息。