add sequantial callback instruction #4503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
哦哦，看到了 441 行的 break 处理了这个顺序依赖关系 |
|
如果指令序列是 A B C，B 是 sequential 指令，C 应该等待 B 的 callback 执行结束再执行吗 |
daquexian
reviewed
Mar 25, 2021
oneflow/core/vm/instruction.msg.h
Outdated
| @@ -219,6 +221,8 @@ OBJECT_MSG_BEGIN(Instruction); | |||
| // links | |||
| OBJECT_MSG_DEFINE_LIST_LINK(instruction_link); | |||
| OBJECT_MSG_DEFINE_LIST_LINK(pending_instruction_link); | |||
| OBJECT_MSG_DEFINE_LIST_LINK(sequantial_infer_instr_link); | |||
不等待，所以才叫回调，否则应该叫barrier。 |
lixinqi
commented
Mar 25, 2021
| @@ -72,7 +84,8 @@ void VirtualMachine::FilterAndRunSourceInstructions(TmpPendingInstrMsgList* inst | |||
| OBJECT_MSG_LIST_FOR_EACH_PTR(instr_msg_list, instr_msg) { | |||
| const auto& instr_type_id = instr_msg->instr_type_id(); | |||
| const StreamType& stream_type = instr_type_id.stream_type_id().stream_type(); | |||
| if (stream_type.SharingVirtualMachineThread() && IsSourceInstruction(*instr_msg)) { | |||
| if (stream_type.SharingVirtualMachineThread() | |||
| && !instr_type_id.instruction_type().IsSequential() && IsSourceInstruction(*instr_msg)) { | |||
There was a problem hiding this comment.
sequential指令基本都是source instruction。但是此处的source instruction执行一定要排除它，否则就是失去了sequential的意义。
daquexian
reviewed
Mar 25, 2021
…ow into sequantial_instruction
lixinqi
commented
Mar 25, 2021
daquexian
approved these changes
Mar 25, 2021
liujuncheng
pushed a commit
that referenced
this pull request
Jun 3, 2021
* add sequantial callback instruction * add a test_case for sequential instruction type * refactor RunLogicalInstruction/RunPhysicalInstruction * refactor RunLogicalInstruction/RunPhysicalInstruction Former-commit-id: a6d0307
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
本pr提供顺序化回调指令。
原本的设计里，由于虚拟机是数据驱动的，指令之间只有简单的数据依赖关系，并没有谁先来谁后来的关系。现在加入了诸如RankSequantialInferCallback/RankSequantialComputeCallback专门用于同步推导和计算。