Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate swish and mish namespace from math to nn #4104

Merged
merged 8 commits into from
Jan 12, 2021
Merged

Migrate swish and mish namespace from math to nn #4104

merged 8 commits into from
Jan 12, 2021

Conversation

MARD1NO
Copy link
Contributor

@MARD1NO MARD1NO commented Jan 11, 2021

为了对齐Pytorch，将 swish和mish 激活算子的命名空间，从 flow.math.xxx 迁移至 flow.nn.xxx

@MARD1NO MARD1NO requested a review from Ldpe2G January 11, 2021 05:59
@Ldpe2G Ldpe2G requested a review from oneflow-ci-bot January 11, 2021 06:28
@oneflow-ci-bot oneflow-ci-bot removed their request for review January 11, 2021 08:19
@oneflow-ci-bot oneflow-ci-bot self-requested a review January 11, 2021 08:28
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 11, 2021 11:25
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 11, 2021 14:54
@oneflow-ci-bot oneflow-ci-bot self-requested a review January 11, 2021 17:59
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 11, 2021 20:52
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 11, 2021 23:41
@oneflow-ci-bot oneflow-ci-bot removed their request for review January 12, 2021 04:10
@oneflow-ci-bot oneflow-ci-bot merged commit 744965c into master Jan 12, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the migrate_swish_mish_to_nn_namespace branch January 12, 2021 04:10
liujuncheng pushed a commit that referenced this pull request Jun 3, 2021
@MARD1NO @oneflow-ci-bot
Migrate swish and mish namespace from math to nn (#4104)
c3574f0 
* migrate namespace

* remove mish code in nn namespace

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
Former-commit-id: 744965c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ldpe2G Ldpe2G Ldpe2G approved these changes

Assignees
No one assigned
Labels
automerge enhancement op python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MARD1NO @Ldpe2G @oneflow-ci-bot