Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mig op arg para attr #4090

Merged
merged 36 commits into from
Jan 9, 2021
Merged

Mig op arg para attr #4090

merged 36 commits into from
Jan 9, 2021

Conversation

clackhan
Copy link
Contributor

@clackhan clackhan commented Jan 8, 2021

迁移OpArgParallelAttribute

@oneflow-ci-bot oneflow-ci-bot removed their request for review January 8, 2021 02:25
@clackhan clackhan removed the request for review from oneflow-ci-bot January 8, 2021 06:57
@clackhan clackhan requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 8, 2021 10:53
@oneflow-ci-bot oneflow-ci-bot removed their request for review January 8, 2021 11:29
@oneflow-ci-bot oneflow-ci-bot removed their request for review January 8, 2021 13:38
@oneflow-ci-bot oneflow-ci-bot removed their request for review January 8, 2021 14:15
@clackhan clackhan requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 8, 2021 18:50
@oneflow-ci-bot oneflow-ci-bot removed their request for review January 8, 2021 21:54
@oneflow-ci-bot oneflow-ci-bot merged commit 41138a5 into master Jan 9, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the mig_op_arg_para_attr branch January 9, 2021 04:20
@@ -15,6 +15,7 @@ import "oneflow/core/graph/boxing/collective_boxing.proto";
import "oneflow/core/job/initializer_conf.proto";
import "oneflow/core/job/regularizer_conf.proto";
import "oneflow/core/job/learning_rate_schedule_conf.proto";
import "oneflow/core/operator/inter_face_blob_conf.proto";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interface 是一个单词吧?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,下的pr更新

liujuncheng pushed a commit that referenced this pull request Jun 3, 2021
* GetPhysicalOpArgBlobAttr

* cfg hash

* fix bug

* cfg::SbpParallel typed OpArgParallelAttribute.sbp_parallel

* cfg::OptMirroredParallel typed OpArgParallelAttribute.opt_mirrored_parallel

* rename PyLazyConsistentBlob and PyLazyMirroredBlob

* fix EagerConsistentBlob bug of property parallel_size

* use static_cast

* del redefine hash

* mig_op_arg_para_attr

* mig DumpToInterfaceBlobConf

* fix bug

* fix inter_face_blob_conf.proto

* replace None with oneflow_api.INVALID_BATCH_AXIS

* mig OpArgBlobAttribute

* make of_format

* add comment

* optimize

* make of_format

* optimize operator==

* fix bug

Co-authored-by: lixinqi <lixinqi0703106@163.com>
Former-commit-id: 41138a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants