-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scalar Pow #4082
Merged
Merged
Add Scalar Pow #4082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into add_scalar_pow
doombeaker
reviewed
Jan 6, 2021
.SetCreateFn<CpuHardSwishKernel<device, dtype>>() \ | ||
.SetIsMatchedHob((HobDeviceTag() == device) \ | ||
& (HobDataType("out", 0) == GetDataType<dtype>::value)); | ||
#define REGISTER_CPU_HARDSWISH_KERNEL(device, dtype) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么另外不相关算子的格式化会在这个PR里。建议拆分成另外的PR。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=,= 因为有个空格,编译的时候会提示几行。 我后面拆分到别的PR吧
doombeaker
reviewed
Jan 6, 2021
doombeaker
reviewed
Jan 6, 2021
doombeaker
reviewed
Jan 6, 2021
doombeaker
reviewed
Jan 6, 2021
doombeaker
reviewed
Jan 6, 2021
doombeaker
approved these changes
Jan 11, 2021
liujuncheng
pushed a commit
that referenced
this pull request
Jun 3, 2021
* Add Scalar Pow CPU version * add backward * add GPU kernel * add test case * add docs example * fix if condition bug * fix * remove change Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> Former-commit-id: fef379e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概述
增加 Scalar 版本的 Pow 运算,参考自 torch.pow,他支持接受 tensor 和 float 作为参数

另外修改了 hardswish 的空格问题
功能 CheckList
Op
Kernel
由于tensor版本的pow,只注册了float32,float64类型。这里为了统一,暂时没有注册 float16 版本
CPU in:float32
CPU in:float64
GPU in:float32
GPU in:float64
Python Wrapper
测试
GPU 有效带宽
理论带宽:
实际带宽:
折合成百分比为 63 %
PR Checklist
bug, enhancement, purge, feature, documentation
)op, system, eager, build, xla, python, ci, test, tooling, onnx
)