Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constant init value #3947

Merged
merged 7 commits into from
Dec 1, 2020
Merged

Conversation

liujuncheng
Copy link
Collaborator

float cast到int可能会异常

@oneflow-ci-bot oneflow-ci-bot removed their request for review December 1, 2020 02:32
@oneflow-ci-bot oneflow-ci-bot removed their request for review December 1, 2020 04:56
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot December 1, 2020 05:25
@oneflow-ci-bot oneflow-ci-bot merged commit 402a56a into master Dec 1, 2020
@oneflow-ci-bot oneflow-ci-bot deleted the fix_constant_init_value_cast branch December 1, 2020 07:52
liujuncheng added a commit that referenced this pull request Dec 3, 2020
* constant fix init value

* refine test

* fix

* fix

Co-authored-by: guo ran <360112263@qq.com>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
liujuncheng added a commit that referenced this pull request Dec 8, 2020
* OptimizerPlacementOptimization

* Fix CollectiveBoxingGenericTaskNode::ProduceAllRegstsAndBindEdges

* fix

* fix

* fix constant attr

* default show cpp error stack frame (#3948)

* add combined margin loss (#3819)

* add combined margin loss

* refine

* skip_unless_1n4d

* skip if cpu only

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Refine custom op build (#3925)

* rm useless code

* refine api & add debug

* refine api

* fix in review

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Fix constant init value (#3947)

* constant fix init value

* refine test

* fix

* fix

Co-authored-by: guo ran <360112263@qq.com>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* fix

* refine

* revert

* fix

* fix

* revert JobBuildAndInferCtx::SetTrainConf

* reformat job_conf.proto

* refine

* test unit test

Co-authored-by: strint <xiaoyulink@gmail.com>
Co-authored-by: guo ran <360112263@qq.com>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
liujuncheng added a commit that referenced this pull request Jun 3, 2021
* constant fix init value

* refine test

* fix

* fix

Co-authored-by: guo ran <360112263@qq.com>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
Former-commit-id: 402a56a
liujuncheng added a commit that referenced this pull request Jun 3, 2021
* OptimizerPlacementOptimization

* Fix CollectiveBoxingGenericTaskNode::ProduceAllRegstsAndBindEdges

* fix

* fix

* fix constant attr

* default show cpp error stack frame (#3948)

* add combined margin loss (#3819)

* add combined margin loss

* refine

* skip_unless_1n4d

* skip if cpu only

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Refine custom op build (#3925)

* rm useless code

* refine api & add debug

* refine api

* fix in review

Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* Fix constant init value (#3947)

* constant fix init value

* refine test

* fix

* fix

Co-authored-by: guo ran <360112263@qq.com>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>

* fix

* refine

* revert

* fix

* fix

* revert JobBuildAndInferCtx::SetTrainConf

* reformat job_conf.proto

* refine

* test unit test

Co-authored-by: strint <xiaoyulink@gmail.com>
Co-authored-by: guo ran <360112263@qq.com>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
Former-commit-id: 05fdee7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants