add stack #3897
Merged
add stack #3897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldpe2G
reviewed
Nov 23, 2020
Ldpe2G
reviewed
Nov 23, 2020
Ldpe2G
reviewed
Nov 23, 2020
Ldpe2G
reviewed
Nov 23, 2020
Ldpe2G
reviewed
Nov 23, 2020
MARD1NO
commented
Nov 24, 2020
| # Evaluate the gradient. Here we only test the reduction type == "mean" | ||
| assert np.allclose(blob, _np_grad) | ||
|
|
||
| # if the stack axis is 0, the batch axis will be change to 1 |
There was a problem hiding this comment.
注：这里的处理逻辑是，如果stack的axis是0（也包括特殊负数情况，使得最终axis=0）那么stack后的tensor，它的batchaxis是会变化的，由0变为1，为了保证后续的multiply能够做正确的elementwise mul，要求两者的batch_axis一致，所以这里进行推断，用于 def oneflow_stack 中的 of_mul参数
Ldpe2G
reviewed
Nov 24, 2020
Ldpe2G
reviewed
Nov 24, 2020
Ldpe2G
reviewed
Nov 24, 2020
Ldpe2G
approved these changes
Dec 16, 2020
liujuncheng
pushed a commit
that referenced
this pull request
Jun 3, 2021
* add stack * add grad check * fix expression * fix detail Co-authored-by: Liang Depeng <liangdepeng@gmail.com> Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com> Former-commit-id: 6941aa7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用 expand_dims + concat 组合出stack算子